<HTML><BODY>Georgy, thank you for the review.<br>Please take a look at updated patch. List of changes:<br>- update wrong comment<br>- rename file and functions iconv_wrap* to tnt_iconv*<br>- remove unnecessary include file<br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Понедельник, 23 июля 2018, 16:17 +03:00 от Georgy Kirichenko <georgy@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15323518380000000297_BODY">Mostly good, but see on my comments bellow<br>
<br>
On Friday, July 20, 2018 7:50:52 PM MSK Konstantin Belyavskiy wrote:<br>
> Fixing build under FreeBSD:<br>
> +# - Find the readline include files and libraries<br>
> +# - Include finding of termcap or curses<br>
Wrong comment<br>
<br>
> +iconv_wrap_open<br>
> +iconv_wrap_close<br>
> +iconv_wrap<br>
I would be like if you renamed this using pattern tnt_<name><br>
> exception_get_string<br>
> exception_get_int<br>
> <br>
> lua/errno.c<br>
> + lua/iconv_wrap.c<br>
I would be like if you used name like tnt_iconv.c<br>
> lua/socket.c<br>
> lua/pickle.c<br>
> lua/fio.c<br>
<br>
> diff --git a/src/lua/iconv_wrap.h b/src/lua/iconv_wrap.h<br>
> new file mode 100644<br>
> index 000000000..03aee40e4<br>
> --- /dev/null<br>
> +++ b/src/lua/iconv_wrap.h<br>
I am do not really sure we need this file<br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>
<br>
<br>Best regards,<br>Konstantin Belyavskiy<br>k.belyavskiy@tarantool.org<br></BODY></HTML>