<HTML><BODY>Thanks for review, now check directory absence with fio.stat()<br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Среда, 18 июля 2018, 6:43 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15318854210000000014_BODY">Hi Kostya!<br>
<br>
The patch looks good for me except one tiny comment.<br>
<br>
WBR, Alexander Turenko.<br>
<br>
<div class="mail-quote-collapse">> index 0850413d9..14e0fb72c 100644<br>
> --- a/test/app/fio.test.lua<br>
> +++ b/test/app/fio.test.lua<br>
> @@ -131,6 +131,13 @@ fio.rmdir(dir2)<br>
> <br>
> { fio.unlink(file1), fio.unlink(file2), fio.unlink(file3), fio.unlink(file4) }<br>
> { fio.unlink(file1), fio.unlink(file2), fio.unlink(file3), fio.unlink(file4) }<br>
> +<br>
> +-- gh-3258 rmtree should remove directories with files<br>
> +fio.mktree('tmp2/tmp3/tmp4')<br>
> +fh = fio.open('tmp2/tmp3/tmp4/tmp.txt', {'O_RDWR', 'O_CREAT'})<br>
> +fh:close()<br>
> +fio.rmtree('tmp2')<br>
> +<br>
</div><br>
I think it would be good to check that the directory really disappears<br>
(via fio.listdir()).<br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>
<br>
<br>Best regards,<br>Konstantin Belyavskiy<br>k.belyavskiy@tarantool.org<br></BODY></HTML>