<HTML><BODY><br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Вторник, 17 июля 2018, 16:13 +03:00 от Vladimir Davydov <vdavydov.dev@gmail.com>:<br><br><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15318332330000000654_BODY">As this is the second version of this patch, you should add v2 to the<br>
subject line and write a brief change log.</div></div></div></div></blockquote>Sorry, I remembered it after sending.<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15318332330000000654_BODY"><br><br>
On Tue, Jul 17, 2018 at 01:25:07PM +0300, Olga Arkhangelskaia wrote:<br>
> Added test to check if the valid syslog configuration is ok.<br>
> <br>
> Issue: #3502<br><br>
Should be:<br><br>
Closes #3502</div></div></div></div></blockquote>Is ir because it is a bug? Because Kirill told me about Issue: and Branch: and then links.<br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15318332330000000654_BODY"><br><br>
> ---<br>
> <a href="https://github.com/tarantool/tarantool/issues/3502" target="_blank">https://github.com/tarantool/tarantool/issues/3502</a><br>
> <br>
> Branch: OKriw/gh-3502-syslog-fix<br>
> ---<br>
> <a href="https://github.com/tarantool/tarantool/tree/OKriw/gh-3502-syslog-fix" target="_blank">https://github.com/tarantool/tarantool/tree/OKriw/gh-3502-syslog-fix</a><br><br>
You misunderstood me. The links shouldn't go to the commit message.<br>
You should open the patch file produced by git-format-patch in your<br>
favorite text editor and add the links manually after --- generated by<br>
git-format-patch. Here's a couple of examples of what a patch email is<br>
supposed to look like:<br><br>
With a cover letter:<br><a href="https://www.freelists.org/post/tarantool-patches/PATCH-v2-02-alter-fix-WAL-error-handling" target="_blank">https://www.freelists.org/post/tarantool-patches/PATCH-v2-02-alter-fix-WAL-error-handling</a><br><br>
Without a cover letter:<br><a href="https://www.freelists.org/post/tarantool-patches/PATCH-v3-Introduce-replica-local-spaces" target="_blank">https://www.freelists.org/post/tarantool-patches/PATCH-v3-Introduce-replica-local-spaces</a><br><br>
Note, neither links nor change log is included in the commit message<br>
once a patch is committed:<br><a href="https://github.com/tarantool/tarantool/commit/f64f46199e19542fa60eede939d62cd115abb83a" target="_blank">https://github.com/tarantool/tarantool/commit/f64f46199e19542fa60eede939d62cd115abb83a</a><br><br>
Please use them as sample.<br></div></div></div></div></blockquote>Ok, thanks<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15318332330000000654_BODY"><br>
> ---<br>
> test/box-tap/cfg.test.lua | 8 +++++++-<br>
> 1 file changed, 7 insertions(+), 1 deletion(-)<br><br>
Please squash the test into the patch with the fix (`git rebase -i`)<br><br>
> <br>
> diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua<br>
> index ffafdbe42..605623013 100755<br>
> --- a/test/box-tap/cfg.test.lua<br>
> +++ b/test/box-tap/cfg.test.lua<br>
> @@ -6,7 +6,7 @@ local socket = require('socket')<br>
> local fio = require('fio')<br>
> local uuid = require('uuid')<br>
> local msgpack = require('msgpack')<br>
> -test:plan(95)<br>
> +test:plan(96)<br>
> <br>
> --------------------------------------------------------------------------------<br>
> -- Invalid values<br>
> @@ -464,5 +464,11 @@ code = string.format(code_fmt, dir, instance_uuid, uuid.new())<br>
> test:is(run_script(code), PANIC, "replicaset_uuid mismatch")<br>
> fio.rmdir(dir)<br>
> <br>
> +--<br>
> +-- Check syslog configuration<br>
> +--<br>
> +code = [[box.cfg{log = 'syslog:identity=tarantool'}]]<br>
> +test:is(run_script(code), 0, "valid log configuration is broken")<br>
> +<br>
> test:check()<br>
> os.exit(0)<br></div></div></div></div></blockquote>
<br>
<br>-- <br>Olga Arkhangelskaia<br></BODY></HTML>