<div dir="ltr"><div>diff --git a/src/box/sql.c b/src/box/sql.c</div><div>index fdce224..398b2a6 100644</div><div>--- a/src/box/sql.c</div><div>+++ b/src/box/sql.c</div><div>@@ -1636,10 +1636,12 @@ sql_debug_info(struct info_handler *h)</div><div> <span style="white-space:pre"> </span>extern int sql_search_count;</div><div> <span style="white-space:pre"> </span>extern int sql_sort_count;</div><div> <span style="white-space:pre"> </span>extern int sql_found_count;</div><div>+<span style="white-space:pre"> </span>extern int sql_xferOpt_count;</div><div> <span style="white-space:pre"> </span>info_begin(h);</div><div> <span style="white-space:pre"> </span>info_append_int(h, "sql_search_count", sql_search_count);</div><div> <span style="white-space:pre"> </span>info_append_int(h, "sql_sort_count", sql_sort_count);</div><div> <span style="white-space:pre"> </span>info_append_int(h, "sql_found_count", sql_found_count);</div><div>+<span style="white-space:pre"> </span>info_append_int(h, "sql_xferOpt_count", sql_xferOpt_count);</div><div> <span style="white-space:pre"> </span>info_end(h);</div><div> }</div><div> </div><div>diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c</div><div>index 2c9188e..9a99bab 100644</div><div>--- a/src/box/sql/insert.c</div><div>+++ b/src/box/sql/insert.c</div><div>@@ -1635,7 +1635,7 @@ sqlite3OpenTableAndIndices(Parse * pParse,<span style="white-space:pre"> </span>/* Parsing context */</div><div> * purposes only - to make sure the transfer optimization really</div><div> * is happening when it is supposed to.</div><div> */</div><div>-int sqlite3_xferopt_count;</div><div>+int sql_xferOpt_count = 0;</div><div> #endif<span style="white-space:pre"> </span>/* SQLITE_TEST */</div><div> </div><div> #ifndef SQLITE_OMIT_XFER_OPT</div><div>@@ -1658,6 +1658,8 @@ xferCompatibleIndex(Index * pDest, Index * pSrc)</div><div> <span style="white-space:pre"> </span>assert(pDest->pTable != pSrc->pTable);</div><div> <span style="white-space:pre"> </span>uint32_t nDestCol = index_column_count(pDest);</div><div> <span style="white-space:pre"> </span>uint32_t nSrcCol = index_column_count(pSrc);</div><div>+<span style="white-space:pre"> </span>if ((pDest->idxType != pSrc->idxType))</div><div>+<span style="white-space:pre"> </span>return 0;</div><div> <span style="white-space:pre"> </span>if (nDestCol != nSrcCol) {</div><div> <span style="white-space:pre"> </span>return 0;<span style="white-space:pre"> </span>/* Different number of columns */</div><div> <span style="white-space:pre"> </span>}</div><div>@@ -1725,9 +1727,9 @@ xferOptimization(Parse * pParse,<span style="white-space:pre"> </span>/* Parser context */</div><div> <span style="white-space:pre"> </span>int emptyDestTest = 0;<span style="white-space:pre"> </span>/* Address of test for empty pDest */</div><div> <span style="white-space:pre"> </span>int emptySrcTest = 0;<span style="white-space:pre"> </span>/* Address of test for empty pSrc */</div><div> <span style="white-space:pre"> </span>Vdbe *v;<span style="white-space:pre"> </span>/* The VDBE we are building */</div><div>-<span style="white-space:pre"> </span>int destHasUniqueIdx = 0;<span style="white-space:pre"> </span>/* True if pDest has a UNIQUE index */</div><div> <span style="white-space:pre"> </span>int regData, regTupleid;<span style="white-space:pre"> </span>/* Registers holding data and tupleid */</div><div> <span style="white-space:pre"> </span>struct session *user_session = current_session();</div><div>+<span style="white-space:pre"> </span>bool is_err_action_default = false;</div><div> </div><div> <span style="white-space:pre"> </span>if (pSelect == NULL)</div><div> <span style="white-space:pre"> </span>return 0;<span style="white-space:pre"> </span>/* Must be of the form INSERT INTO ... SELECT ... */</div><div>@@ -1744,8 +1746,10 @@ xferOptimization(Parse * pParse,<span style="white-space:pre"> </span>/* Parser context */</div><div> <span style="white-space:pre"> </span>if (onError == ON_CONFLICT_ACTION_DEFAULT) {</div><div> <span style="white-space:pre"> </span>if (pDest->iPKey >= 0)</div><div> <span style="white-space:pre"> </span>onError = pDest->keyConf;</div><div>-<span style="white-space:pre"> </span>if (onError == ON_CONFLICT_ACTION_DEFAULT)</div><div>+<span style="white-space:pre"> </span>if (onError == ON_CONFLICT_ACTION_DEFAULT) {</div><div> <span style="white-space:pre"> </span>onError = ON_CONFLICT_ACTION_ABORT;</div><div>+<span style="white-space:pre"> </span>is_err_action_default = true;</div><div>+<span style="white-space:pre"> </span>}</div><div> <span style="white-space:pre"> </span>}</div><div> <span style="white-space:pre"> </span>assert(pSelect->pSrc);<span style="white-space:pre"> </span>/* allocated even if there is no FROM clause */</div><div> <span style="white-space:pre"> </span>if (pSelect->pSrc->nSrc != 1) {</div><div>@@ -1848,9 +1852,6 @@ xferOptimization(Parse * pParse,<span style="white-space:pre"> </span>/* Parser context */</div><div> <span style="white-space:pre"> </span>}</div><div> <span style="white-space:pre"> </span>}</div><div> <span style="white-space:pre"> </span>for (pDestIdx = pDest->pIndex; pDestIdx; pDestIdx = pDestIdx->pNext) {</div><div>-<span style="white-space:pre"> </span>if (index_is_unique(pDestIdx)) {</div><div>-<span style="white-space:pre"> </span>destHasUniqueIdx = 1;</div><div>-<span style="white-space:pre"> </span>}</div><div> <span style="white-space:pre"> </span>for (pSrcIdx = pSrc->pIndex; pSrcIdx; pSrcIdx = pSrcIdx->pNext) {</div><div> <span style="white-space:pre"> </span>if (xferCompatibleIndex(pDestIdx, pSrcIdx))</div><div> <span style="white-space:pre"> </span>break;</div><div>@@ -1888,72 +1889,60 @@ xferOptimization(Parse * pParse,<span style="white-space:pre"> </span>/* Parser context */</div><div> <span style="white-space:pre"> </span> * least a possibility, though it might only work if the destination</div><div> <span style="white-space:pre"> </span> * table (tab1) is initially empty.</div><div> <span style="white-space:pre"> </span> */</div><div>-#ifdef SQLITE_TEST</div><div>-<span style="white-space:pre"> </span>sqlite3_xferopt_count++;</div><div>-#endif</div><div>+</div><div> <span style="white-space:pre"> </span>v = sqlite3GetVdbe(pParse);</div><div> <span style="white-space:pre"> </span>iSrc = pParse->nTab++;</div><div> <span style="white-space:pre"> </span>iDest = pParse->nTab++;</div><div> <span style="white-space:pre"> </span>regData = sqlite3GetTempReg(pParse);</div><div> <span style="white-space:pre"> </span>regTupleid = sqlite3GetTempReg(pParse);</div><div> <span style="white-space:pre"> </span>sqlite3OpenTable(pParse, iDest, pDest, OP_OpenWrite);</div><div>-<span style="white-space:pre"> </span>assert(destHasUniqueIdx);</div><div>-<span style="white-space:pre"> </span>if ((pDest->iPKey < 0 && pDest->pIndex != 0)<span style="white-space:pre"> </span>/* (1) */</div><div>-<span style="white-space:pre"> </span> ||destHasUniqueIdx<span style="white-space:pre"> </span>/* (2) */</div><div>-<span style="white-space:pre"> </span> || (onError != ON_CONFLICT_ACTION_ABORT</div><div>-<span style="white-space:pre"> </span>&& onError != ON_CONFLICT_ACTION_ROLLBACK)<span style="white-space:pre"> </span>/* (3) */</div><div>-<span style="white-space:pre"> </span> ) {</div><div>-<span style="white-space:pre"> </span>/* In some circumstances, we are able to run the xfer optimization</div><div>-<span style="white-space:pre"> </span> * only if the destination table is initially empty.</div><div>-<span style="white-space:pre"> </span> * This block generates code to make</div><div>-<span style="white-space:pre"> </span> * that determination.</div><div>-<span style="white-space:pre"> </span> *</div><div>-<span style="white-space:pre"> </span> * Conditions under which the destination must be empty:</div><div>-<span style="white-space:pre"> </span> *</div><div>-<span style="white-space:pre"> </span> * (1) There is no INTEGER PRIMARY KEY but there are indices.</div><div>-<span style="white-space:pre"> </span> *</div><div>-<span style="white-space:pre"> </span> * (2) The destination has a unique index. (The xfer optimization</div><div>-<span style="white-space:pre"> </span> * is unable to test uniqueness.)</div><div>-<span style="white-space:pre"> </span> *</div><div>-<span style="white-space:pre"> </span> * (3) onError is something other than ON_CONFLICT_ACTION_ABORT and _ROLLBACK.</div><div>-<span style="white-space:pre"> </span> */</div><div>+</div><div>+<span style="white-space:pre"> </span>struct space *src_space =</div><div>+<span style="white-space:pre"> </span>space_by_id(SQLITE_PAGENO_TO_SPACEID(pSrc->tnum));</div><div>+<span style="white-space:pre"> </span>struct space *dest_space =</div><div>+<span style="white-space:pre"> </span>space_by_id(SQLITE_PAGENO_TO_SPACEID(pDest->tnum));</div><div>+<span style="white-space:pre"> </span>struct index *src_idx = space_index(src_space, 0);</div><div>+<span style="white-space:pre"> </span>struct index *dest_idx = space_index(dest_space, 0);</div><div>+</div><div>+<span style="white-space:pre"> </span>/* Xfer optimization is unable to correctly insert data</div><div>+<span style="white-space:pre"> </span> * in case there's a conflict action other than *_ABORT.</div><div>+<span style="white-space:pre"> </span> * This is the reason we want to only run it if the</div><div>+<span style="white-space:pre"> </span> * destination table is initially empty.</div><div>+<span style="white-space:pre"> </span> * That block generates code to make that determination.</div><div>+<span style="white-space:pre"> </span> */</div><div>+</div><div>+<span style="white-space:pre"> </span>if (!(onError == ON_CONFLICT_ACTION_ABORT &&</div><div>+<span style="white-space:pre"> </span> is_err_action_default == false)) {</div><div> <span style="white-space:pre"> </span>addr1 = sqlite3VdbeAddOp2(v, OP_Rewind, iDest, 0);</div><div> <span style="white-space:pre"> </span>VdbeCoverage(v);</div><div> <span style="white-space:pre"> </span>emptyDestTest = sqlite3VdbeAddOp0(v, OP_Goto);</div><div> <span style="white-space:pre"> </span>sqlite3VdbeJumpHere(v, addr1);</div><div>+#ifdef SQLITE_TEST</div><div>+<span style="white-space:pre"> </span>if (dest_idx->vtab->count(dest_idx, ITER_ALL, NULL, 0) == 0)</div><div>+<span style="white-space:pre"> </span>sql_xferOpt_count++;</div><div>+#endif</div><div> <span style="white-space:pre"> </span>}</div><div>-</div><div>-<span style="white-space:pre"> </span>for (pDestIdx = pDest->pIndex; pDestIdx; pDestIdx = pDestIdx->pNext) {</div><div>-<span style="white-space:pre"> </span>for (pSrcIdx = pSrc->pIndex; ALWAYS(pSrcIdx);</div><div>-<span style="white-space:pre"> </span> pSrcIdx = pSrcIdx->pNext) {</div><div>-<span style="white-space:pre"> </span>if (xferCompatibleIndex(pDestIdx, pSrcIdx))</div><div>-<span style="white-space:pre"> </span>break;</div><div>-<span style="white-space:pre"> </span>}</div><div>-<span style="white-space:pre"> </span>assert(pSrcIdx);</div><div>-<span style="white-space:pre"> </span>struct space *src_space =</div><div>-<span style="white-space:pre"> </span>space_by_id(SQLITE_PAGENO_TO_SPACEID(pSrcIdx->tnum));</div><div>-<span style="white-space:pre"> </span>vdbe_emit_open_cursor(pParse, iSrc,</div><div>-<span style="white-space:pre"> </span> SQLITE_PAGENO_TO_INDEXID(pSrcIdx->tnum),</div><div>-<span style="white-space:pre"> </span> src_space);</div><div>-<span style="white-space:pre"> </span>VdbeComment((v, "%s", pSrcIdx->zName));</div><div>-<span style="white-space:pre"> </span>struct space *dest_space =</div><div>-<span style="white-space:pre"> </span>space_by_id(SQLITE_PAGENO_TO_SPACEID(pDestIdx->tnum));</div><div>-<span style="white-space:pre"> </span>vdbe_emit_open_cursor(pParse, iDest,</div><div>-<span style="white-space:pre"> </span> SQLITE_PAGENO_TO_INDEXID(pDestIdx->tnum),</div><div>-<span style="white-space:pre"> </span> dest_space);</div><div>-<span style="white-space:pre"> </span>VdbeComment((v, "%s", pDestIdx->zName));</div><div>-<span style="white-space:pre"> </span>addr1 = sqlite3VdbeAddOp2(v, OP_Rewind, iSrc, 0);</div><div>-<span style="white-space:pre"> </span>VdbeCoverage(v);</div><div>-<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_RowData, iSrc, regData);</div><div>-<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_IdxInsert, iDest, regData);</div><div>-<span style="white-space:pre"> </span>if (pDestIdx->idxType == SQLITE_IDXTYPE_PRIMARYKEY)</div><div>-<span style="white-space:pre"> </span>sqlite3VdbeChangeP5(v, OPFLAG_NCHANGE);</div><div>-<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_Next, iSrc, addr1 + 1);</div><div>-<span style="white-space:pre"> </span>VdbeCoverage(v);</div><div>-<span style="white-space:pre"> </span>sqlite3VdbeJumpHere(v, addr1);</div><div>-<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_Close, iSrc, 0);</div><div>-<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_Close, iDest, 0);</div><div>+#ifdef SQLITE_TEST</div><div>+<span style="white-space:pre"> </span>else {</div><div>+<span style="white-space:pre"> </span>sql_xferOpt_count++;</div><div> <span style="white-space:pre"> </span>}</div><div>+#endif</div><div>+</div><div>+<span style="white-space:pre"> </span>vdbe_emit_open_cursor(pParse, iSrc, 0, src_space);</div><div>+<span style="white-space:pre"> </span>VdbeComment((v, "%s", src_idx->def->name));</div><div>+<span style="white-space:pre"> </span>vdbe_emit_open_cursor(pParse, iDest, 0, dest_space);</div><div>+<span style="white-space:pre"> </span>VdbeComment((v, "%s", dest_idx->def->name));</div><div>+<span style="white-space:pre"> </span>addr1 = sqlite3VdbeAddOp2(v, OP_Rewind, iSrc, 0);</div><div>+<span style="white-space:pre"> </span>VdbeCoverage(v);</div><div>+<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_RowData, iSrc, regData);</div><div>+<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_IdxInsert, iDest, regData);</div><div>+<span style="white-space:pre"> </span>sqlite3VdbeChangeP5(v, OPFLAG_NCHANGE);</div><div>+<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_Next, iSrc, addr1 + 1);</div><div>+<span style="white-space:pre"> </span>VdbeCoverage(v);</div><div>+<span style="white-space:pre"> </span>sqlite3VdbeJumpHere(v, addr1);</div><div>+<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_Close, iSrc, 0);</div><div>+<span style="white-space:pre"> </span>sqlite3VdbeAddOp2(v, OP_Close, iDest, 0);</div><div>+</div><div> <span style="white-space:pre"> </span>if (emptySrcTest)</div><div> <span style="white-space:pre"> </span>sqlite3VdbeJumpHere(v, emptySrcTest);</div><div> <span style="white-space:pre"> </span>sqlite3ReleaseTempReg(pParse, regTupleid);</div><div>diff --git a/test/sql-tap/gh-3307-xfer-optimization-issue.test.lua b/test/sql-tap/gh-3307-xfer-optimization-issue.test.lua</div><div>new file mode 100755</div><div>index 0000000..e75fabc</div><div>--- /dev/null</div><div>+++ b/test/sql-tap/gh-3307-xfer-optimization-issue.test.lua</div><div>@@ -0,0 +1,706 @@</div><div>+#!/usr/bin/env tarantool</div><div>+test = require("sqltester")</div><div>+test:plan(44)</div><div>+</div><div>+local bfr, aftr</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.1",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b INTEGER UNIQUE);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (2, 2), (3, 3);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b INTEGER UNIQUE);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.1></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.1></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.2",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.2></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 3</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.2></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.3",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(id INTEGER PRIMARY KEY, b INTEGER);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(id INTEGER PRIMARY KEY, b INTEGER);</div><div>+<span style="white-space:pre"> </span>CREATE INDEX i1 ON t1(b);</div><div>+<span style="white-space:pre"> </span>CREATE INDEX i2 ON t2(b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (2, 2), (3, 3);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.3></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.3></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.4",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.4></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 3</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.4></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.5",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b INTEGER, c INTEGER);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1, 2), (2, 2, 3), (3, 3, 4);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b INTEGER);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.5></div><div>+<span style="white-space:pre"> </span>1, "table T2 has 2 columns but 3 values were supplied"</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.5></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.6",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.6></div><div>+</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.6></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.7",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b INTEGER);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (2, 2), (3, 3);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b INTEGER);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.7></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.7></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.8",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.6></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 3</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.6></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.9",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b INTEGER);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (2, 2), (3, 2);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(b INTEGER, a INTEGER PRIMARY KEY);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.9></div><div>+<span style="white-space:pre"> </span>1, "Duplicate key exists in unique index 'sqlite_autoindex_T2_1' in space 'T2'"</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.9></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.10",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.10></div><div>+</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.10></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.11",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b INTEGER);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (2, 2), (3, 2);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(b INTEGER PRIMARY KEY, a INTEGER);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.11></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.11></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.12",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.12></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 2</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.12></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.13",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (3, 3), (4, 4), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (1, 1), (2, 2);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.13></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.13></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.14",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.14></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 3, 4, 4, 5, 5</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.14></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.15",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b UNIQUE);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b UNIQUE);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (2, 2), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (1, 1), (4, 4);</div><div>+<span style="white-space:pre"> </span>INSERT OR ROLLBACK INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.15></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.15></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.16",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.16></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 3, 4, 4, 5, 5</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.16></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- The following tests are supposed to test if xfer-optimization is actually</div><div>+-- used in the given cases (if the conflict actually occurs):</div><div>+-- <span style="white-space:pre"> </span>1.0) insert w/o explicit confl. action & w/o index replace action</div><div>+-- <span style="white-space:pre"> </span>1.1) insert w/o explicit confl. action & w/ index replace action & empty dest_table</div><div>+-- <span style="white-space:pre"> </span>1.2) insert w/o explicit confl. action & w/ index replace action & non-empty dest_table</div><div>+-- <span style="white-space:pre"> </span>2) insert with abort</div><div>+-- <span style="white-space:pre"> </span>3.0) insert with rollback (into empty table)</div><div>+-- <span style="white-space:pre"> </span>3.1) insert with rollback (into non-empty table)</div><div>+-- <span style="white-space:pre"> </span>4) insert with replace</div><div>+-- <span style="white-space:pre"> </span>5) insert with fail</div><div>+-- <span style="white-space:pre"> </span>6) insert with ignore</div><div>+</div><div>+</div><div>+-- 1.0) insert w/o explicit confl. action & w/o index replace action</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.17",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (2, 2), (3, 4);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (4, 4);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.17></div><div>+<span style="white-space:pre"> </span>1, "Duplicate key exists in unique index 'sqlite_autoindex_T2_1' in space 'T2'"</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.17></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.18",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (10, 10);</div><div>+<span style="white-space:pre"> </span>COMMIT;</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.18></div><div>+<span style="white-space:pre"> </span>2, 2, 3, 4, 4, 4, 10, 10</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.18></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.19",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.19></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.19></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- 1.1) insert w/o explicit confl. action & w/ index replace action & empty dest_table</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.20",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY ON CONFLICT REPLACE, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY ON CONFLICT REPLACE, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t3(id INT PRIMARY KEY);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT INTO t3 VALUES (1);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.20></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.20></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.21",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (10, 10);</div><div>+<span style="white-space:pre"> </span>COMMIT;</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.21></div><div>+<span style="white-space:pre"> </span>1, 1, 3, 3, 5, 5, 10, 10</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.21></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.22",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t3;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.22></div><div>+<span style="white-space:pre"> </span>1</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.22></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.23",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.23></div><div>+<span style="white-space:pre"> </span>1</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.23></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- 1.2) insert w/o explicit confl. action & w/ index replace action & non-empty dest_table</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.24",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t3;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY ON CONFLICT REPLACE, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY ON CONFLICT REPLACE, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (2, 2), (3, 4);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (4, 4);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.24></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.24></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.25",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (10, 10);</div><div>+<span style="white-space:pre"> </span>COMMIT;</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.25></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 10, 10</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.25></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.26",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.26></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.26></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- 2) insert with abort</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.27",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (2, 2), (3, 4);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (4, 4);</div><div>+<span style="white-space:pre"> </span>INSERT OR ABORT INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.27></div><div>+<span style="white-space:pre"> </span>1, "Duplicate key exists in unique index 'sqlite_autoindex_T2_1' in space 'T2'"</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.27></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.28",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (10, 10);</div><div>+<span style="white-space:pre"> </span>COMMIT;</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.28></div><div>+<span style="white-space:pre"> </span>2, 2, 3, 4, 4, 4, 10, 10</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.28></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.29",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.29></div><div>+<span style="white-space:pre"> </span>1</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.29></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- 3.0) insert with rollback (into empty table)</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.30",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT OR ROLLBACK INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.30></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.30></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.31",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (10, 10);</div><div>+<span style="white-space:pre"> </span>COMMIT;</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.31></div><div>+<span style="white-space:pre"> </span>1, 1, 3, 3, 5, 5, 10, 10</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.31></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.32",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.32></div><div>+<span style="white-space:pre"> </span>1</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.32></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- 3.1) insert with rollback (into non-empty table)</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.33",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (2, 2), (3, 4);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (4, 4);</div><div>+<span style="white-space:pre"> </span>INSERT OR ROLLBACK INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.33></div><div>+<span style="white-space:pre"> </span>1, "UNIQUE constraint failed: T2.A"</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.33></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.34",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.34></div><div>+<span style="white-space:pre"> </span>2, 2, 3, 4</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.34></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.35",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.35></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.35></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- 4) insert with replace</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.36",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (2, 2), (3, 4);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (4, 4);</div><div>+<span style="white-space:pre"> </span>INSERT OR REPLACE INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.36></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.36></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.37",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (10, 10);</div><div>+<span style="white-space:pre"> </span>COMMIT;</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.37></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 10, 10</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.37></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.38",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.38></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.38></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- 5) insert with fail</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.39",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (2, 2), (3, 4);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (4, 4);</div><div>+<span style="white-space:pre"> </span>INSERT OR FAIL INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.39></div><div>+<span style="white-space:pre"> </span>1, "Duplicate key exists in unique index 'sqlite_autoindex_T2_1' in space 'T2'"</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.39></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.40",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (10, 10);</div><div>+<span style="white-space:pre"> </span>COMMIT;</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.40></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 4, 4, 4, 10, 10</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.40></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.41",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.41></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.41></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+-- 6) insert with ignore</div><div>+-------------------------------------------------------------------------------------------</div><div>+</div><div>+bfr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_catchsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.42",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>DROP TABLE t1;</div><div>+<span style="white-space:pre"> </span>DROP TABLE t2;</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t1(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>CREATE TABLE t2(a INTEGER PRIMARY KEY, b);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t1 VALUES (1, 1), (3, 3), (5, 5);</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (2, 2), (3, 4);</div><div>+<span style="white-space:pre"> </span>BEGIN;</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (4, 4);</div><div>+<span style="white-space:pre"> </span>INSERT OR IGNORE INTO t2 SELECT * FROM t1;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.42></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.42></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:do_execsql_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.43",</div><div>+<span style="white-space:pre"> </span>[[</div><div>+<span style="white-space:pre"> </span>INSERT INTO t2 VALUES (10, 10);</div><div>+<span style="white-space:pre"> </span>COMMIT;</div><div>+<span style="white-space:pre"> </span>SELECT * FROM t2;</div><div>+<span style="white-space:pre"> </span>]], {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.43></div><div>+<span style="white-space:pre"> </span>1, 1, 2, 2, 3, 4, 4, 4, 5, 5, 10, 10</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.43></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+aftr = box.sql.debug().sql_xferOpt_count</div><div>+</div><div>+test:do_test(</div><div>+<span style="white-space:pre"> </span>"xfer-optimization-1.44",</div><div>+<span style="white-space:pre"> </span>function()</div><div>+<span style="white-space:pre"> </span>if (aftr - bfr == 1) then</div><div>+<span style="white-space:pre"> </span>return {1}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>if (aftr == bfr) then</div><div>+<span style="white-space:pre"> </span>return {0}</div><div>+<span style="white-space:pre"> </span>end</div><div>+<span style="white-space:pre"> </span>return {2}</div><div>+<span style="white-space:pre"> </span>end, {</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.44></div><div>+<span style="white-space:pre"> </span>0</div><div>+<span style="white-space:pre"> </span>-- <xfer-optimization-1.44></div><div>+<span style="white-space:pre"> </span>})</div><div>+</div><div>+test:finish_test()</div><div><br></div><br><div class="gmail_quote"><div dir="ltr">пн, 16 июл. 2018 г. в 22:12, n.pettik <<a href="mailto:korablev@tarantool.org">korablev@tarantool.org</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
> Here's diff for the fixed and rebased patch. There're some unexpected things concerned with the check of emptiness of destination table: internals can only correctly deal with ABORT conflict action and also my 'small optimization of optimization' was incorrect.<br>
<br>
I see no diff, actually. You haven’t attached it to the letter.</blockquote></div></div>