<HTML><BODY><div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15254213820000000171_BODY"><div class="class_1525451652">
<div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix">
<style></style>
<div>
<div id="style_15249290350000000598_BODY_mailru_css_attribute_postfix"><div class="class_1525429619_mailru_css_attribute_postfix">
<div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix">
<style></style>
<div>
<div id="style_15248440480000000672_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="class_1524945231_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15248268620000000885_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">Hello. Do not start commit subject with capital letter after ‘:’.<br></div></div></div></div></blockquote>Fixed.<blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15248268620000000885_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">
Also, I don’t see your branch at remote repository:<br>
you should push it before sending patch<br>
(in order to check Travis status, at least).</div></div></div></div></blockquote>Pushed. <a href="https://github.com/tarantool/tarantool/tree/sb/scip-scan-fix" target="_blank" rel=" noopener noreferrer">https://github.com/tarantool/tarantool/tree/sb/scip-scan-fix</a> <br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15248268620000000885_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">The limit for commit message is 72 chars…<br>
Just reminding you.</div></div></div></div></blockquote>I am confused. 72 chars is a limit for the whole commit<br>message? <blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15248268620000000885_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">
Just enumerate with comma:<br>
Closes #xxxx, #xxxx</div></div></div></div></blockquote>Ok.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15248268620000000885_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">Put here link to the branch and link to the issue</div></div></div></div></blockquote>Ok.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15248268620000000885_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">Make sure that code fits into 80 chars. Now I can’t check it,<br>
since you haven’t pushed your branch.<br></div></div></div></div></blockquote>I am confused again. What is this 80-chars constraint about?<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15248268620000000885_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">I would add to the name of test number of issue:<br>
gh-xxxx-skip-scan.test.lua<br><br>
Or, if it covers several issues, put comments before<br>
test cases indicating number of issue it belongs to.</div></div></div></div></blockquote>Fxd.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15248268620000000885_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">Consider formatting of curly braces.<br></div></div></div></div></blockquote>
Fxd.<br>
<br>-- <br>Ivan Koptelov<br><style></style>
</div></div>
</div>
</div>
</div></div>
</div>
</div>
</div></div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div></BODY></HTML>