<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hello. I have noticed that you are using 4 spaces as an indentation.<div class="">According to our codestyle, we use tab symbol, instead of spaces,</div><div class="">which is equal to 8 spaces.</div><div class=""><br class=""></div><div class="">Also, I don’t see any point in renaming function:</div><div class="">’sql_clear_stat_spaces’ -> ’sql_clear_stat_tables’.</div><div class="">I would even say that ‘spaces’ is more appropriate name,</div><div class="">since stat tables in fact are Tarantool’s system spaces.</div><div class=""><br class=""><div><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="gmail_quote"><div class="">diff --git a/src/box/sql/build.c b/src/box/sql/build.c</div><div class="">index 92f3cb6..7ca4191 100644</div><div class="">--- a/src/box/sql/build.c</div><div class="">+++ b/src/box/sql/build.c</div><div class="">@@ -2128,19 +2128,33 @@ sqliteViewResetAll(sqlite3 * db)</div><div class=""> /**</div><div class=""> * Remove entries from the _sql_stat1 and _sql_stat4</div><div class=""> * system spaces after a DROP INDEX or DROP TABLE command.</div><div class="">- *</div><div class="">- * @param pParse Parsing context.</div><div class="">- * @param zType Type of entry to be deleted:</div><div class="">- * <span style="white-space:pre-wrap" class=""> </span>'idx' or 'tbl' string literal.</div><div class="">- * @param zName Name of index or table.</div><div class="">+ * </div><div class="">+ * @param parse The parsing context.</div><div class="">+ * @param table_name The table to be dropped or</div><div class="">+ * the table that contains index to be dropped.</div><div class="">+ * @param idx_name Index to be dropped.</div><div class=""> */</div><div class=""> static void</div><div class="">-sql_clear_stat_spaces(Parse * pParse, const char *zType, const char *zName)</div><div class="">+sql_clear_stat_tables(Parse *parse, const char *table_name,</div><div class="">+ const char *idx_name)</div><div class=""> {</div><div class="">-<span style="white-space:pre-wrap" class=""> </span>sqlite3NestedParse(pParse, "DELETE FROM \"_sql_stat1\" WHERE \"%s\"=%Q",</div><div class="">-<span style="white-space:pre-wrap" class=""> </span> zType, zName);</div><div class="">-<span style="white-space:pre-wrap" class=""> </span>sqlite3NestedParse(pParse, "DELETE FROM \"_sql_stat4\" WHERE \"%s\"=%Q",</div><div class="">-<span style="white-space:pre-wrap" class=""> </span> zType, zName);</div><div class="">+ if (idx_name != NULL) {</div><div class="">+ sqlite3NestedParse(parse,</div><div class="">+ "DELETE FROM \"_sql_stat1\" WHERE (\"idx\"=%Q AND "</div><div class="">+ "\"tbl\"=%Q)",</div><div class="">+ idx_name, table_name);</div><div class="">+ sqlite3NestedParse(parse,</div><div class="">+ "DELETE FROM \"_sql_stat4\" WHERE (\"idx\"=%Q AND "</div><div class="">+ "\"tbl\"=%Q)",</div><div class="">+ idx_name, table_name);</div><div class="">+ } else {</div><div class="">+ sqlite3NestedParse(parse,</div><div class="">+ "DELETE FROM \"_sql_stat1\" WHERE \"tbl\"=%Q",</div><div class="">+ table_name);</div><div class="">+ sqlite3NestedParse(parse,</div><div class="">+ "DELETE FROM \"_sql_stat4\" WHERE \"tbl\"=%Q",</div><div class="">+ table_name);</div><div class="">+ }</div><div class=""> }</div><div class=""><br class=""></div><div class=""> </div></div></div></blockquote></div></div>
</blockquote></div><br class=""></div></body></html>