<HTML><BODY>Hi, this is old version of my commit, which i accidentally send. I resend correct version. Is it available?<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Четверг, 29 марта 2018, 13:10 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15223182310000000113_BODY">Hi, Gleb!<br>
<br>
Please, squash your two commits into one and resend the patch.<br>
<br>
WBR, Alexander Turenko.<br>
<br>
On Sun, Mar 25, 2018 at 03:28:25AM +0300, Gleb wrote:<br>
> Issue from <a href="https://github.com/tarantool/tarantool/issues/2165" target="_blank">https://github.com/tarantool/tarantool/issues/2165</a>.<br>
> Source from <a href="https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes" target="_blank">https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes</a>.<br>
<br>
Place it under --- mark.<br>
<br>
> Remove support partial indexes.<br>
> Add test which check inaccessibility of partial index syntax.<br>
> Comment tests which use partial index, they can be uncomment when partial index will be available.<br>
<br>
The line length exceeds 72 symbols.<br>
<br>
> Fixed comments as per review.<br>
<br>
That should not be part of the commit message.<br>
<br>
> <br>
> Fixes #2165<br>
> ---<br>
<br>
Here you should place issue/branch names, changelog and other things<br>
that should not be part of the commit.<br>
<br>
> src/box/sql/build.c | 11 +-<br>
> src/box/sql/parse.c | 205 +++++++++---------<br>
> src/box/sql/parse.y | 2 +-<br>
> test/sql-tap/analyze9.test.lua | 18 +-<br>
> test/sql-tap/autoindex4.test.lua | 5 +-<br>
> test/sql-tap/fkey1.test.lua | 1 -<br>
> test/sql-tap/index6.test.lua | 437 +++++++++++++++++++--------------------<br>
> test/sql-tap/suite.ini | 1 +<br>
> 8 files changed, 333 insertions(+), 347 deletions(-)<br>
><br>
> ...<br>
><br>
> diff --git a/test/sql-tap/analyze9.test.lua b/test/sql-tap/analyze9.test.lua<br>
> index 472bad7..206ae16 100755<br>
> --- a/test/sql-tap/analyze9.test.lua<br>
> +++ b/test/sql-tap/analyze9.test.lua<br>
> ...<br>
> @@ -1177,9 +1172,9 @@ test:do_execsql_test(<br>
> -- [[<br>
> -- EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE d IS NOT NULL AND a=0 AND b=0 AND c=10;<br>
> -- ]], {<br>
> --- -- <17.6><br>
> + -- <17.6><br>
> -- 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX I2 (C=? AND D>?)"<br>
> --- -- </17.6><br>
> + -- </17.6><br>
> -- })<br>
> <br>
<br>
Use -- *at start* of each line for the entire block or --[[ ... ]]--.<br>
I'm about '<17.6>' lines.<br>
<br>
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini<br>
> index 0bc9e83..d6ce75e 100644<br>
> --- a/test/sql-tap/suite.ini<br>
> +++ b/test/sql-tap/suite.ini<br>
> @@ -3,3 +3,4 @@ core = app<br>
> description = Database tests with #! using TAP<br>
> lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua<br>
> is_parallel = True<br>
> +disabled = index6.test.lua;<br>
<br>
Space before ';' is needed according to [1]. Write a comment with the<br>
issue re partial index enabling (#2626), please.<br>
<br>
> -- <br>
> 2.7.4<br>
> <br>
<br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>
<br>
<br><br></BODY></HTML>