<HTML><BODY><div class="js-helper js-readmsg-msg">
        <style type="text/css"></style>
        <div>
                <base target="_self" href="https://e.mail.ru/">
                
            <div id="style_15180172080000000322_BODY"><div class="class_1518039873">
<div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix">
        <style></style>
        <div>
                
                
            <div id="style_15180163040000000923_BODY_mailru_css_attribute_postfix"><div class="class_1518033449_mailru_css_attribute_postfix">
<br><br><br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;">
        Среда,  7 февраля 2018, 17:21 +03:00 от Yaroslav Dynnikov <<a href="//e.mail.ru/compose/?mailto=mailto%3ayaroslav.dynnikov@tarantool.org" target="_blank" rel=" noopener noreferrer">yaroslav.dynnikov@tarantool.org</a>>:<br><br><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15180133090000000003_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="class_1518042898_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div dir="ltr">branch: gh-3040-http-over-unix-request-opts<br><div><br><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From d00b44afbfab06beb98495991e267bf10e53f334 Mon Sep 17 00:00:00 2001<br>From: Konstantin Belyavskiy <<a href="//e.mail.ru/compose/?mailto=mailto%3ak.belyavskiy@tarantool.org" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">k.belyavskiy@tarantool.org</a>><br>Date: Tue, 6 Feb 2018 19:27:37 +0300<br>Subject: [PATCH] Fix OSX tests and add compile-time check<br><br>Add compile-time libcurl version check to make sure it supports<br>Unix socket (by using CURL_VERSION_UNIX_SOCKETS macro)<br><br>Closes #3040<br>---<br> src/httpc.c                       | 12 +++++++++++-<br> src/httpc.h                       |  3 ++-<br> src/lua/httpc.c                   |  5 ++++-<br> test/app-tap/http_client.test.lua | 22 ++++++++++++++++++++--<br> 4 files changed, 37 insertions(+), 5 deletions(-)<br><br>diff --git a/src/httpc.c b/src/httpc.c<br>index 5eb79f00e..bba5e8cde 100644<br>--- a/src/httpc.c<br>+++ b/src/httpc.c<br>@@ -263,10 +263,20 @@ httpc_set_ca_file(struct httpc_request *req, const char *ca_file)<br>     curl_easy_setopt(req->curl_request.easy, CURLOPT_CAINFO, ca_file);<br> }<br><br>-void<br>+int<br> httpc_set_unix_socket(struct httpc_request *req, const char *unix_socket)<br> {<br>+#ifdef CURL_VERSION_UNIX_SOCKETS<br>     curl_easy_setopt(req->curl_request.easy, CURLOPT_UNIX_SOCKET_PATH, unix_socket);<br>+    return 0;<br></blockquote><div>This part still doesnt look consistent. Why is the curl_easy_setopt error ignored?<br></div><div>My proposal:<br></div><div>if (CURLE_OK == curl_easy_setopt(...)) {<br>    return 0;<br>} else {<br>    return -1;<br>}<br></div></div></div></div></div></div></div></div></blockquote>Decided to do everything the same way. Every function here shadow curl errors. Error handling could be done .. but as a separate commit and in all similar places.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15180133090000000003_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="class_1518042898_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div dir="ltr"><div><div><br></div><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+#else<br>+#pragma message "UNIX_SOCKETS are not supported, please upgrade curl to 7.40.0"<br>+    (void) req;<br>+    (void) unix_socket;<br>+    diag_set(IllegalParams, "please upgrade libcurl to 7.40"<br>+                " to support unix socket");<br></blockquote><div>diag_set message is irrelevant to runtime. Yet pragma is OK.<br></div><div>My proposal: "tarantool was build without unix socket support"<br>Because upgrading libcurl won't change anything in runtime.</div></div></div></div></div></div></div></div></blockquote>It's very rare situation then someone got Tarantool binary build with old curl but possible. Update warning diag_set message.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15180133090000000003_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="class_1518042898_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div dir="ltr"><div><div><br><br></div><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+    return -1;<br>+#endif<br></blockquote><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> }<br><br> void<br>diff --git a/src/httpc.h b/src/httpc.h<br>index 8e85bd905..6e3267f2d 100644<br>--- a/src/httpc.h<br>+++ b/src/httpc.h<br>@@ -227,8 +227,9 @@ httpc_set_ca_file(struct httpc_request *req, const char *ca_file);<br>  * endpoint instead of TCP. The application does not have to keep the string<br>  * around after setting this option.<br>  * @see <a href="https://curl.haxx.se/libcurl/c/CURLOPT_UNIX_SOCKET_PATH.html" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">https://curl.haxx.se/libcurl/c/CURLOPT_UNIX_SOCKET_PATH.html</a><br>+ * @return 0 on success<br></blockquote><div>Could you please mention @return -1 if the option is not supported<br><br></div><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">  */<br>-void<br>+int<br> httpc_set_unix_socket(struct httpc_request *req, const char *unix_socket);<br><br> /**<br>diff --git a/src/lua/httpc.c b/src/lua/httpc.c<br>index 937d15fc8..a217e3c59 100644<br>--- a/src/lua/httpc.c<br>+++ b/src/lua/httpc.c<br>@@ -124,7 +124,10 @@ luaT_httpc_request(lua_State *L)<br><br>     lua_getfield(L, 5, "unix_socket");<br>     if (!lua_isnil(L, -1))<br>-        httpc_set_unix_socket(req, lua_tostring(L, -1));<br>+        if(httpc_set_unix_socket(req, lua_tostring(L, -1))) {<br>+            httpc_request_delete(req);<br>+            return luaT_error(L);<br>+        }<br>     lua_pop(L, 1);<br><br>     lua_getfield(L, 5, "verify_host");<br>diff --git a/test/app-tap/http_client.test.lua b/test/app-tap/http_client.test.lua<br>index 274ac4d1f..c0a66946f 100755<br>--- a/test/app-tap/http_client.test.lua<br>+++ b/test/app-tap/http_client.test.lua<br>@@ -391,6 +391,15 @@ test:test('http over AF_INET', function(test)<br> end)<br><br> test:test('http over AF_UNIX', function(test)<br>+    local url = "<a href="http://localhost/" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">http://localhost/</a>"<br>+    local tmpname = os.tmpname()<br>+    local sock = tmpname .. '.sock'<br>+    local ok = pcall(client.get, url, {unix_socket=sock, timeout = 0.01})<br>+    if ok == false then<br></blockquote><div>I don't like this check. It states that "if client.get FAILS for ANY reason  the check is marked as PASSED". But it is not.</div></div></div></div></div></div></div></div></blockquote>I think it's ok. Probability of such case is low. It could be done but I don't think it's really needed.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15180133090000000003_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="class_1518042898_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div dir="ltr"><div><div><br><br></div><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+        os.remove(tmpname)<br>+        return<br>+    end<br>+<br></blockquote><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">     test:plan(8)<br><br>     local tmpname = os.tmpname()<br></blockquote><div>Don't override tmpname or the previous file will not be deleted from tmp</div></div></div></div></div></div></div></div></blockquote>fixed<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="style_15180133090000000003_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="class_1518042898_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div dir="ltr"><div><div><br><br></div><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">@@ -400,9 +409,14 @@ test:test('http over AF_UNIX', function(test)<br>     local cmd = string.format("%s/test/app-tap/httpd.py --unix %s",<br>             TARANTOOL_SRC_DIR, sock)<br>     local server = io.popen(cmd)<br>+    if server == nil then<br>+        test:diag("create server failes")<br></blockquote><div>typo: "server creation failed"<br><br></div><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+        os.remove(tmpname)<br>+        os.remove(sock)<br>+        return<br>+    end<br>     test:is(server:read("*l"), "heartbeat", "server started")<br><br>-    local url = "<a href="http://localhost/" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">http://localhost/</a>"<br>     test:diag("trying to connect to %s", url)<br>     local r<br>     for i=1,10 do<br>@@ -428,7 +442,11 @@ test:test('http over AF_UNIX', function(test)<br>     test:test("basic http post/get", post_and_get_test, url, opts)<br>     test:test("headers", headers_test, url, opts)<br>     test:test("special methods", special_methods_test, url, opts)<br>-    test:test("concurrent", concurrent_test, url, opts)<br>+    if jit.os == "OSX" then -- due to difference in OSX Unix socket, skip<br>+        test:skip("concurrent")<br>+    else<br>+        test:test("concurrent", concurrent_test, url, opts)<br>+    end<br></blockquote><div>Agree<br><br></div><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>     -- STOP SERVER<br>     test:diag("stopping HTTP server")<br>-- <br>2.14.3 (Apple Git-98)<br></blockquote><br><br><div class="gmail_extra_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><br><div class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">On 7 February 2018 at 15:34, Konstantin Belyavskiy <span dir="ltr"><<a href="//e.mail.ru/compose/?mailto=mailto%3ak.belyavskiy@tarantool.org" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">k.belyavskiy@tarantool.org</a>></span> wrote:<br><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>branch: gh-3040-http-over-unix-request-opts<br><br><br><br><blockquote style="border-left:1px solid rgb(8,87,166);margin:10px;padding:0px 0px 0px 10px">
        Среда,  7 февраля 2018, 13:53 +03:00 от Vladimir Davydov <<a href="//e.mail.ru/compose/?mailto=mailto%3avdavydov.dev@gmail.com" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">vdavydov.dev@gmail.com</a>>:<br><br><div id="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964style_15180008190000000301_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix">On Tue, Feb 06, 2018 at 08:11:31PM +0300, Konstantin Belyavskiy wrote:<br>
                                 > Add compile-time libcurl version check to make sure it supports<br>
> Unix socket (by using CURL_VERSION_UNIX_SOCKETS macro)<br>
> <br>
> Closes #3040<br>
> ---<br>
> branch: gh-3040-http-over-unix-request-opts<br>
>  src/httpc.c                       | 10 +++++++++-<br>
>  src/httpc.h                       |  3 ++-<br>
>  src/lua/httpc.c                   |  4 +++-<br>
>  test/app-tap/http_client.test.lua | 26 +++++++++++++++++++++++---<br>
>  4 files changed, 37 insertions(+), 6 deletions(-)<br>
> <br>
> diff --git a/src/httpc.c b/src/httpc.c<br>
> index 5eb79f00e..f3c6a1c0e 100644<br>
> --- a/src/httpc.c<br>
> +++ b/src/httpc.c<br>
> @@ -263,10 +263,18 @@ httpc_set_ca_file(struct httpc_request *req, const char *ca_file)<br>
>    curl_easy_setopt(req->curl_request.easy, CURLOPT_CAINFO, ca_file);<br>
>  }<br>
>  <br>
> -void<br>
> +int<br>
>  httpc_set_unix_socket(struct httpc_request *req, const char *unix_socket)<br>
>  {<br>
> +#ifdef CURL_VERSION_UNIX_SOCKETS<br>
>    curl_easy_setopt(req->curl_request.easy, CURLOPT_UNIX_SOCKET_PATH, unix_socket);<br>
> +  return 0;<br>
> +#else<br>
> +#pragma message "UNIX_SOCKETS are not supported, please upgrade curl to 7.40.0"<br>
> +  (void) req;<br>
> +  (void) unix_socket;<br>
> +  return -1;<br>
> +#endif<br>
>  }<br><br>
This is minor, but we usually set diag on error. What about<br>
IllegalParams? Another option - silently ignore the option if<br>
it is not supported, as we do in case of httpc_set_keepalive -<br>
let httpc_execute fail if unix connections are not supported.<br></div></div></div></div></blockquote>Fixed<br><blockquote style="border-left:1px solid rgb(8,87,166);margin:10px;padding:0px 0px 0px 10px"><div id="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964style_15180008190000000301_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><br>
>  <br>
>  void<br><br>
> diff --git a/src/lua/httpc.c b/src/lua/httpc.c<br>
> index 937d15fc8..577e614df 100644<br>
> --- a/src/lua/httpc.c<br>
> +++ b/src/lua/httpc.c<br>
> @@ -124,7 +124,9 @@ luaT_httpc_request(lua_State *L)<br>
>  <br>
>    lua_getfield(L, 5, "unix_socket");<br>
>    if (!lua_isnil(L, -1))<br>
> -          httpc_set_unix_socket(req, lua_tostring(L, -1));<br>
> +          if(httpc_set_unix_socket(req, lua_tostring(L, -1)))<br>
> +                  return luaL_error(L, "please upgrade libcurl to 7.40"<br>
> +                                       " to support unix socket");<br><br>
AFAICS httpc_request_delete must be called in case of error.</div></div></div></div></blockquote>Fixed<br><blockquote style="border-left:1px solid rgb(8,87,166);margin:10px;padding:0px 0px 0px 10px"><div id="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964style_15180008190000000301_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><br><br>
>    lua_pop(L, 1);<br>
>  <br>
>    lua_getfield(L, 5, "verify_host");<br>
> diff --git a/test/app-tap/http_client.test.lua b/test/app-tap/http_client.test.lua<br>
> index 274ac4d1f..6289b5b92 100755<br>
> --- a/test/app-tap/http_client.test.lua<br>
> +++ b/test/app-tap/http_client.test.lua<br>
> @@ -391,7 +391,20 @@ test:test('http over AF_INET', function(test)<br>
>  end)<br>
>  <br>
>  test:test('http over AF_UNIX', function(test)<br>
> -    test:plan(8)<br>
> +    local url = "<a href="http://localhost/" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">http://localhost/</a>"<br>
> +    local tmpname = os.tmpname()<br>
> +    local sock = tmpname .. '.sock'<br>
> +    local check = pcall(client.get, url, {unix_socket=sock, timeout = 0.01})<br>
> +    if check == false then<br>
> +        os.remove(tmpname)<br>
> +        return<br>
> +    end<br>
> +<br>
> +    local extra = 1<br>
> +    if jit.os == "OSX" then<br>
> +        extra = 0<br>
> +    end<br>
> +    test:plan(extra + 7)<br>
>  <br>
>      local tmpname = os.tmpname()<br>
>      local sock = tmpname .. '.sock'<br>
> @@ -400,9 +413,14 @@ test:test('http over AF_UNIX', function(test)<br>
>      local cmd = string.format("%s/test/app-tap/httpd.py --unix %s",<br>
>              TARANTOOL_SRC_DIR, sock)<br>
>      local server = io.popen(cmd)<br>
> +    if server == nil then<br>
> +        test:diag("create server failes")<br>
> +        os.remove(tmpname)<br>
> +        os.remove(sock)<br>
> +        return<br>
> +    end<br>
>      test:is(server:read("*l"), "heartbeat", "server started")<br>
>  <br>
> -    local url = "<a href="http://localhost/" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">http://localhost/</a>"<br>
>      test:diag("trying to connect to %s", url)<br>
>      local r<br>
>      for i=1,10 do<br>
> @@ -428,7 +446,9 @@ test:test('http over AF_UNIX', function(test)<br>
>      test:test("basic http post/get", post_and_get_test, url, opts)<br>
>      test:test("headers", headers_test, url, opts)<br>
>      test:test("special methods", special_methods_test, url, opts)<br>
> -    test:test("concurrent", concurrent_test, url, opts)<br>
> +    if jit.os ~= "OSX" then<br>
> +        test:test("concurrent", concurrent_test, url, opts)<br>
> +    end<br><br>
Why is that? At least, it deserves a comment.<br></div></div></div></div></blockquote>Add comment<br><blockquote style="border-left:1px solid rgb(8,87,166);margin:10px;padding:0px 0px 0px 10px"><div id="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div class="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964js-helper_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964js-readmsg-msg_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><div><div id="gmail-m_-2811625258223901052gmail-m_-4502570813579616376m_-4882784776236589964style_15180008190000000301_BODY_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix"><br>
Anyway, I think the series is split in patches incorrectly.<br>
Currently, we have on the branch:<br><br>
19e911d3 Fix OSX tests and add compile-time check<br>
9c607ad4 Refactor http.client autotests<br>
e766c6b3 Allow http client connection to use unix socket<br><br>
Patch #1 (the last one on the list above) introduces the http-over-unix<br>
feature, but doesn't add a test. Besides, it doesn't even work if curl<br>
is older than a certain version. That is, the patch is incomplete.<br><br>
Patch #2 not just refactors the test, as the comment claims, but also<br>
partially adds a test for patch #1, which is confusing.<br><br>
Patch #3 is a fix for patch #1 plus the remnants of the test.<br><br>
How I see the series: patch #1 prepares the http client test for testing<br>
http-over-unix without adding any new cases; patch #2 introduces the<br>
feature with a test and without any bugs.<br></div></div></div></div></blockquote>
I can merge them in one, OK?<br></div></blockquote><div>I agree, merge them all in one when you finish.<br></div><blockquote class="gmail_quote_mailru_css_attribute_postfix_mailru_css_attribute_postfix_mailru_css_attribute_postfix" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><br>С уважением,<br>Konstantin Belyavskiy<br><a href="//e.mail.ru/compose/?mailto=mailto%3ak.belyavskiy@tarantool.org" target="_blank" rel="noopener noreferrer  noopener noreferrer  noopener noreferrer">k.belyavskiy@tarantool.org</a><br></div></blockquote></div><br></div></div></div></div></div></div></div></div></blockquote>
<br>
<br>С уважением,<br>Konstantin Belyavskiy<br><a href="//e.mail.ru/compose/?mailto=mailto%3ak.belyavskiy@tarantool.org" target="_blank" rel=" noopener noreferrer">k.belyavskiy@tarantool.org</a><br>
</div></div>
            
        
                
        </div>

        
</div>
</div></div>
            
        
                <base target="_self" href="https://e.mail.ru/">
        </div>

        
</div></BODY></HTML>