[Tarantool-patches] [PATCH luajit v3 2/3] ci: enabled sanitizer tests for macOS
Evgeniy Temirgaleev
e.temirgaleev at tarantool.org
Tue Sep 29 13:33:00 MSK 2026
Hi, Sergey! The comment's place change is reverted.
The branch is force pushed.
28.09.2026 16:10, Sergey Bronnikov пишет:
> Hi, Evgeniy,
>
> thanks for fixes! LGTM with a minor comment.
>
> On 9/24/26 11:49, Evgeniy Temirgaleev wrote:
>>
>>>
>>> 3. I don't like that we have three copies of ASAN_OPTIONS in the same
>>> workflow. It is better to fix this.
>>
>> Fixed.
>
> Thanks!
>
> Why this hunk was moved? Please revert:
>
> +
> + # Enable as much checks as possible. See more info here:
> + # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags,
> + # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags.
> + - name: setup common sanitizer options
> env:
> - # Enable as much checks as possible. See more info here:
> - # https://github.com/google/sanitizers/wiki/
> AddressSanitizerFlags,
> - # https://github.com/google/sanitizers/wiki/
> SanitizerCommonFlags.
> ASAN_OPTIONS: " \
> detect_invalid_pointer_pairs=1: \
> detect_leaks=1:
--
diff --git a/.github/workflows/sanitizers-testing.yml
b/.github/workflows/sanitizers-testing.yml
index bc163408..b8eaf581 100644
--- a/.github/workflows/sanitizers-testing.yml
+++ b/.github/workflows/sanitizers-testing.yml
@@ -114,11 +114,11 @@ jobs:
- name: build
run: cmake --build . --parallel
working-directory: ${{ env.BUILDDIR }}
- # Enable as much checks as possible. See more info here:
- # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags,
- # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags.
- name: setup common sanitizer options
env:
+ # Enable as much checks as possible. See more info here:
+ #
https://github.com/google/sanitizers/wiki/AddressSanitizerFlags,
+ # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags.
ASAN_OPTIONS: " \
detect_invalid_pointer_pairs=1: \
detect_leaks=1: \
--
Best regards,
Evgeniy Temirgaleev
More information about the Tarantool-patches
mailing list