[Tarantool-patches] [PATCH luajit] test: disabled flaky test for OSX/ARM64
Sergey Kaplun
skaplun at tarantool.org
Tue Oct 13 19:36:01 MSK 2026
Hi, Evgeniy!
Thanks for the patch and fixes!
I've taken a look at the last-pushed branch version.
LGTM, with minor comment below.
On 29.09.26, Evgeniy Temirgaleev wrote:
> Hi, Sergey! Thanks for review. Please, see my answers below.
>
> The branch is force pushed with new commit message.
>
> 28.09.2026 15:45, Sergey Bronnikov пишет:
<snipped>
> >> ---
> >> .../fix-mips64-spare-side-exit-patching.test.lua | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/test/tarantool-tests/fix-mips64-spare-side-exit-
> >> patching.test.lua b/test/tarantool-tests/fix-mips64-spare-side-exit-
> >> patching.test.lua
> >> index dd9f2073..0a9e230f 100644
> >> --- a/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua
> >> +++ b/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua
> >> @@ -4,6 +4,8 @@ local test = tap.test('fix-mips64-spare-side-exit-
> >> patching'):skipcond({
> >> ['Disabled on *BSD due to #4819'] = jit.os == 'BSD',
> >> -- We need to fix the MIPS behaviour first.
> >> ['Disabled for MIPS architectures'] = jit.arch:match('mips'),
> >> + ['Disabled on *OSX/ARM64 due to #13261'] = jit.os == 'OSX' and
> >
> > s/*OSX/macOS/
>
> Fixed, thanks!
It looks like this fix wasn't pushed to the remote branch. Please update
it too.
<snipped>
> --
> Best regards,
> Evgeniy Temirgaleev
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list