[Tarantool-patches] [PATCH luajit] ARM64: Don't fuse sign extensions into logical operands.
Sergey Kaplun
skaplun at tarantool.org
Wed Nov 18 11:31:21 MSK 2026
Hi, Evgeniy!
Thanks for the review!
On 17.11.26, Evgeniy Temirgaleev wrote:
> Hi, Sergey! Thanks for the patch! LGTM with a note.
>
> On 11/16/26 3:05 PM, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Thanks to Peter Cawley.
> >
> > (cherry picked from commit 90742d91c27d185b70d1b4a6343fb6b7c26002db)
> >
> > Logical instructions [1] (`orr`, etc.) have no sign extension form
> > (unlike `ADD Xd, Xn, Wm, SXTW #k`). This makes the fusing sign extension
> > into them meaningless and leads to the incorrect result in the
> > JIT-compiled code.
> >
> > This patch prevents the fusing of sign extension (`sxtw`) into logical
> > instructions.
> >
> > [1]: https://cybersandeep.gitbook.io/arm64basicguide/chapter-3-basic-arm64-instructions#id-3.2.2-logical-instructions
> The article contains only basic form of arithmetic and logical (and
> other) instructions. It omits their complex forms with optional second
> operand shift and/or extension and is not illustrative for this patch.
Yes, I've failed to find the definition of the logical instructions at
the non-blocked resources :(. At least it has the definition of logical
instruction...
Do you think it is better to remove the link to avoid the confusion?
>
> >
> > Sergey Kaplun:
> > * added the description and the test for the problem
> >
> > Part of tarantool/tarantool#13442
> > ---
<snipped>
> --
> Best regards,
> Evgeniy Temirgaleev
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list