[Tarantool-patches] [PATCH luajit 1/2] Prevent recording of loops with -0 step or NaN values.
Sergey Bronnikov
sergeyb at tarantool.org
Mon Mar 16 11:22:50 MSK 2026
Hi, Sergey,
thanks for update. LGTM then.
Sergey
On 3/16/26 10:37, Sergey Kaplun wrote:
> Sergey,
>
> Updated the comment as we discussed offline.
> Branch is force-pushed.
>
> On 13.03.26, Sergey Kaplun via Tarantool-patches wrote:
>>
<snipped>
> Made the comment more verbose:
Thanks, I suppose it is more clear now for readers.
>
> ===================================================================
> diff --git a/test/tarantool-tests/lj-1432-minus-zero-step.test.lua b/test/tarantool-tests/lj-1432-minus-zero-step.test.lua
> index 112153dc..e3b97dde 100644
> --- a/test/tarantool-tests/lj-1432-minus-zero-step.test.lua
> +++ b/test/tarantool-tests/lj-1432-minus-zero-step.test.lua
> @@ -42,7 +42,7 @@ end
>
> local function test_trace_recorded(test_payload)
> jit.flush()
> - -- Reset hotcounters.
> + -- XXX: Reset hotcounters to avoid false-positive collisions.
> jit.opt.start('hotloop=1', 'hotexit=1')
> test_payload()
> return traceinfo(1)
> diff --git a/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua b/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua
> index b9e5ad92..f7566d6a 100644
> --- a/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua
> +++ b/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua
> @@ -62,7 +62,7 @@ end
>
> local function test_trace_recorded(test_payload)
> jit.flush()
> - -- Reset hotcounters.
> + -- XXX: Reset hotcounters to avoid false-positive collisions.
> jit.opt.start('hotloop=1', 'hotexit=1')
> test_payload()
> return traceinfo(1)
> ===================================================================
>
>>> <snipped>
>> --
>> Best regards,
>> Sergey Kaplun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20260316/4595817a/attachment.htm>
More information about the Tarantool-patches
mailing list