[Tarantool-patches] [PATCH luajit 2/2] ARM: Make hard-float tobit conversions match JIT backend behavior.
Sergey Kaplun
skaplun at tarantool.org
Fri Jul 24 14:03:11 MSK 2026
Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.
On 24.07.26, Sergey Bronnikov wrote:
> Hello,
>
> thanks for the patch! LGTM with a minor comment
>
> Sergey
>
> On 7/21/26 17:53, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Reported by Peter Cawley.
> >
> > (cherry picked from commit 32a683d226a3b57adbfeabff17d1ae0f7676545d)
> >
> > On the arm architecture, the `tobit()` function incorrectly truncates
> s/arm/ARM/
Fixed, thanks.
> > instead of rounding to the nearest integer. This leads to inconsistency
> > between various VMs (comparing to x86/x64, for example) and between the
> > arm VM and JIT.
> >
> > This patch uses an addition of 2^52 + 2^51 constant to the given
> > argument to convert it to the nearest integer value. After reading the
> > lowest 32 bits of the register, we get the expected result.
> >
> > The test is the same as for the previous commit.
> >
> > Sergey Kaplun:
> > * added the description for the problem
> >
> > Part of tarantool/tarantool#12880
> > ---
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list