[Tarantool-patches] [PATCH v2 luajit 18/41] perf: adjust nsieve-bit-fp in LuaJIT-benches

[Sergey Kaplun]

Hi, Sergey!
Thanks for the review!
Please consider my answer below.

On 15.01.26, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch!
> 
> Sergey
> 
> On 12/26/25 12:17, Sergey Kaplun wrote:
> 
> <snipped>
> 
> > +  checker = function(res)
> > +    if N == DEFAULT_N then
> > +      assert(res[0] == 2488465)
> > +      assert(res[1] == 1299069)
> > +      assert(res[2] == 679461)
> 
> Minor: I would leave a comment about magic numbers or use variables with 
> self-explained names.

>From the code and the comment in the header, it is clear that this is the
number of prime numbers till `(2 ^ (12 - i)) * 10000`.

> 
> Feel free to ignore.

Ignoring.

> 
> > +    end
> > +    return true
> > +  end,
> > +}
> > +
> > +bench:add(benchmark)
> > +bench:run_and_report()

-- 
Best regards,
Sergey Kaplun