[Tarantool-patches] [PATCH luajit] ci: unused gcc removed from macOS setup

Sergey Kaplun skaplun at tarantool.org
Mon Aug 17 15:32:12 MSK 2026


Hi, Evgeniy!
Thanks for the patch!
LGTM, with minor nits regarding the commit message.

On 08.08.26, Evgeniy Temirgaleev wrote:
> From: Temir Galeev <temir.galeev at bk.ru>
> 
> The brew gcc installation is useless, because cmake use

Typo: s/use/uses/

> the clang compiler which is already present in the system.

Typo: s/compiler/compiler,/

> 
> Also, the clang is better than gcc for macOS.
> 
> Branch: https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac

Side note: It's better to insert the additional info under --- below to
avoid confusion with the commit message.

> 
> ---
>  .github/actions/setup-macos/action.yml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml
> index 91632648..9e752a70 100644
> --- a/.github/actions/setup-macos/action.yml
> +++ b/.github/actions/setup-macos/action.yml

<snipped>

> 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list