[Tarantool-patches] [PATCH luajit v2 1/3] build: fixed making tests with ASAN on OSX

Sergey Kaplun skaplun at tarantool.org
Tue Aug 4 23:53:32 MSK 2026


Sorry, I've noticed some nits regarding the commit message.
LGTM, after fixing.

> build: fixed making tests with ASAN on OSX

It also may use tag `test:`, Feel free to ignore.

On 31.07.26, Evgeniy Temirgaleev wrote:
> From: Temir Galeev <temir.galeev at bk.ru>
> 
> LuaJIT tests use fixup for Linux to run binaries maked with ASAN option.

Typo: s/maked/made/ or s/maked/built/
Typo: s/ASAN/the ASAN/

> The our LibRealPath module used for it. This module doesn't support OSX

Typo: s/The our/Our/
Typo: s/used/is used/

> and breaks the make process.
> 
> So, we disable the fixup for OSX to allow LuaJIT making and running the tests

Commit message body is more than 72 symbols [1].

> with ASAN enabled.

<snipped>

[1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list