[Tarantool-patches] [PATCH luajit] Fix IR_ABC hoisting.
Sergey Kaplun
skaplun at tarantool.org
Thu Mar 20 15:38:34 MSK 2025
Hi, Sergey!
Thanks for the review!
Fixed your comments, rebased the branch on the tarantool/master
and force-pushed it.
On 20.03.25, Sergey Bronnikov wrote:
> Hi, Sergey!
>
> thanks for the patch! LGTM with minor comments that can be ignored.
>
> Sergey
>
> On 27.02.2025 19:00, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
<snipped>
> > +local function test_func()
> > + -- 1 iteration for hotcount warm-up. 2 and 3 to record invariant
>
> As usually we care about readers, I propose to make text more
> human-firendly:
>
> s/1/The first/
>
> s/2 and 3/second and third/
>
Fixed, see the iterative patch below.
===================================================================
diff --git a/test/tarantool-tests/lj-1194-abc-hoisting.test.lua b/test/tarantool-tests/lj-1194-abc-hoisting.test.lua
index 3a78c34e..57fbc584 100644
--- a/test/tarantool-tests/lj-1194-abc-hoisting.test.lua
+++ b/test/tarantool-tests/lj-1194-abc-hoisting.test.lua
@@ -39,9 +39,10 @@ local table_new = require('table.new')
jit.opt.start('hotloop=1', '-fuse')
local function test_func()
- -- 1 iteration for hotcount warm-up. 2 and 3 to record invariant
- -- and variant parts of the loop. The trace is run via an
- -- additional call to this function.
+ -- The first iteration for hotcount warm-up. The second and
+ -- third are needed to record invariant and variant parts of the
+ -- loop. The trace is run via an additional call to this
+ -- function.
local limit = 3
-- Create a table with a fixed array size (`limit` + 1), so all
-- access to it fits into the array part.
===================================================================
> > + -- and variant parts of the loop. The trace is run via an
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list