[Tarantool-patches] [PATCH luajit 3/3] Fix state restore when recording __concat metamethod.

Sergey Kaplun skaplun at tarantool.org
Thu Mar 13 13:28:28 MSK 2025


Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.

On 12.03.25, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch! LGTM wit ha minor comment.
> 
> Sergey
> 
> On 10.03.2025 17:51, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Reported by Sergey Kaplun.
> >
> > (cherry picked from commit eee16efa77b542e99c8e546a3d52fc023925c7bc)
> >
> > This commit is a follow-up to the previous one. It fixes the case when
> > the `topslot` is adjusting for simple concatenation results. This patch
> > adds the update of the corresponding Lua stack slots to be restored.
> >
> > This fixes back the <lj-839-concat-recording.test.lua> test.
> >
> > Sergey Kaplun:
> > * added the description and the test for the problem
> 
> It is partially true actually :)
> 
> s/and the test//

Yes, the force of the habit (and copy-paste ;))

> 
> >
> > Part of tarantool/tarantool#11055
> > ---

<snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list