[Tarantool-patches] [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64
Sergey Kaplun
skaplun at tarantool.org
Mon Jul 21 15:29:49 MSK 2025
Hi, Sergey!
Thanks for the review!
On 21.07.25, Sergey Bronnikov wrote:
> Hello, Sergey,
>
> thanks for the patch!
>
> > [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64
>
> s/or/on/?
No, since I've meant that either Tarantool or the corresponding arch
doesn't run this test.
>
> On 7/21/25 11:16, Sergey Kaplun wrote:
> > The test may lead to the assertion failure if run under Tarantool.
> > Also, the skip condition for the Tarantool leads to stable fails for
> > some builds on x86/x64 architecture, so they are skipped as well.
> > See details in the comment to the skip conditions.
> > ---
>
> I suppose you want to disable it temporarily, do we need an issue as a
> reminder?
I suppose not. It should be enabled back alongside the backporting
commit for the 1369.
>
> LGTM
> >
> > Branch:https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool
> >
> > Originally I want to disable the test only for Tarantool, but faced
> > multiple failures in the different workflows:
> > https://github.com/tarantool/luajit/actions/runs/16410069543
> >
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list