[Tarantool-patches] [PATCH v3 luajit] Fix command-line argv handling.

Sergey Bronnikov sergeyb at tarantool.org
Tue Jan 28 12:03:08 MSK 2025


Sergey,


thanks for the patch! LGTM with a minor comment.

Sergey

On 27.01.2025 13:18, Sergey Kaplun wrote:


<snipped>

> diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
> index c4a402d0..c84c651d 100644
> --- a/test/tarantool-c-tests/CMakeLists.txt
> +++ b/test/tarantool-c-tests/CMakeLists.txt
> @@ -41,6 +41,14 @@ file(GLOB tests "${CMAKE_CURRENT_SOURCE_DIR}/*${CTEST_SRC_SUFFIX}")
>   foreach(test_source ${tests})
>     # Get test name without suffix. Needed to set OUTPUT_NAME.
>     get_filename_component(exe ${test_source} NAME_WE)
> +
> +  # Test requires static build, since it inspects internal
> +  # symbols.
> +  if(exe STREQUAL "gh-8594-sysprof-ffunc-crash"
> +      AND BUILDMODE STREQUAL "dynamic")
please put AND to the previous line and fix indentation
<snipped>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20250128/abe2725a/attachment.htm>


More information about the Tarantool-patches mailing list