[Tarantool-patches] [PATCH luajit 2/7] sysprof: align test title with test filename

Sergey Kaplun skaplun at tarantool.org
Tue Feb 18 14:10:12 MSK 2025


Hi, Sergey!
Thanks fro the patch!
LGTM, except a minor nits below.

> sysprof: align test title with test filename

It should be `test:`, since we don't change the sysprof component
itself, only test for it.

On 13.02.25, Sergey Bronnikov wrote:
> The patch fixes TAP test title to make it aligned with test
> filename. Inconsistency introduced in commit
> efd7e1a67de24464e1e83793e16eac6df443e3c0
> ("test: make skipcond helper more convenient").

I am afraid that this naming was introduced in the first commit related
to the tests (sysprof and memprof).

> ---
>  test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua | 2 +-

Should it be fixed for the memprof too?

>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
> index 237143ad..32fa384c 100644
> --- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
> +++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua

<snipped>

> -- 
> 2.34.1
> 

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list