[Tarantool-patches] [PATCH luajit] Fix recording of BC_VARG.

Sergey Kaplun skaplun at tarantool.org
Mon Feb 10 18:18:39 MSK 2025


Hi, Sergey!
Thanks for the review!
Fixed your comments and force-pushed the branch.

On 10.02.25, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch! LGTM with a minor comment.
> 
> Sergey
> 
> On 07.02.2025 16:05, Sergey Kaplun wrote:
> 
> 
> <snipped>
> 
> > +jit.opt.start('hotloop=1')
> > +test:is(test_func(EXPECTED), EXPECTED, 'corect BC_VARG recording')
> Typo: "corect"

Fixed and force-pushed to the branch.
Also, rebased to the current master.
See the iterative patch below:

===================================================================
diff --git a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
index 20b43e07..b3a62b5c 100644
--- a/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
+++ b/test/tarantool-tests/fix-recording-bc-varg-used-in-select.test.lua
@@ -31,6 +31,6 @@ local function test_func(...)
 end
 
 jit.opt.start('hotloop=1')
-test:is(test_func(EXPECTED), EXPECTED, 'corect BC_VARG recording')
+test:is(test_func(EXPECTED), EXPECTED, 'correct BC_VARG recording')
 
 test:done(true)
===================================================================

> > +
> > +test:done(true)

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list