[Tarantool-patches] [PATCH luajit] Handle all stack layouts in (delayed) TRACE vmevent.

Sergey Kaplun skaplun at tarantool.org
Fri Feb 7 13:49:54 MSK 2025


Hi, Sergey!
Thanks for the fixes and the answers.

On 05.02.25, Sergey Bronnikov wrote:

<snipped>

> >> +	lua_pushcfunction(L, (lua_CFunction)cb);
> >> +	if (event != NULL) {
> > Nit: Brackets are excess.
> > Feel free to ignore.
> 
> Removed, anyway it is a test code and without braces it looks more clean.
> 
> However, I'm always enclosing statements in loop/if/else in braces,
> 
> because I remember about "goto fail" issue [1].
> 
> 1. https://dwheeler.com/essays/apple-goto-fail.html

Side note: I believe that the reason here is not the goto `usage` or
code without braces. But this is more like a philosophic question to
discuss. :)

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list