[Tarantool-patches] [PATCH v1 luajit 40/41] perf: provide CMake option to setup the benchmark

[Sergey Kaplun]

Hi, Sergey!
Thanks for the review.
Please, consider my answers below.

On 18.11.25, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch! See my comments.
> 
> Sergey
> 
> On 10/24/25 14:00, Sergey Kaplun wrote:
> > This patch introduces the `LUAJIT_BENCH_INIT` option to determine the
> 
> it is actually a runner for benchmark, not a command that runs before 
> the benchmark itself.
> 
> Please rephrase.

Rephrased as discussed offline.

> 
> 
> I would rename a cmake option appropriately. 
> LUAJIT_BENCH_EXEC/LUAJIT_BENCH_RUNNER?

I prefer to leave it as is to be consistent with namings in tests.

> 
> Feel free to keep as is, I don't insist.
> 
> > shell command to be run before the benchmark itself. It may be useful to
> > set taskset, etc.
> > ---

The updated commit message is the following:

| perf: provide CMake option to setup the benchmark
|
| This patch introduces the `LUAJIT_BENCH_INIT` option to determine the
| shell command prefix to be run before the benchmark itself. It may be
| useful to set taskset, etc.

> >   perf/CMakeLists.txt | 9 ++++++++-
> >   1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/perf/CMakeLists.txt b/perf/CMakeLists.txt
> > index 68e561fd..c315597f 100644
> > --- a/perf/CMakeLists.txt
> > +++ b/perf/CMakeLists.txt
> > @@ -7,6 +7,13 @@ if(CMAKE_BUILD_TYPE STREQUAL "Debug")
> >                     "Timings may be affected.")
> >   endif()
> >   
> > +# The shell command needs to be run before benchmarks are started.
> > +if(LUAJIT_BENCH_INIT)
> > +  message(STATUS
> > +    "The following command will run before benchmarks: '${LUAJIT_BENCH_INIT}'."
> > +  )
> > +endif()
> this message is not necessary, one can see it in "ctest -V" output

I suppose it is good to mention it in the configuration phase as well.

<snipped>

-- 
Best regards,
Sergey Kaplun