[Tarantool-patches] [PATCH v1 luajit 28/41] perf: move <scimark_lib.lua> to <libs/> directory
Sergey Kaplun
skaplun at tarantool.org
Fri Dec 26 11:32:43 MSK 2025
Hi, Sergey!
Thanks for the review.
Please, consider my answers below.
On 17.11.25, Sergey Bronnikov wrote:
> Hi, Sergey,
>
> thanks for the patch! LGTM with a minor comment:
>
> I propose to squash this patch with patch "perf: add CMake infrastructure"
I prefer to leave it as is to make diff clear.
>
> or add to the commit message "Needed for ...".
Needed for is used for the ticket mentioning. There is no ticket about
this, so ignoring. The commit message contains the rationale. The patch
itself was done in this order before refactoring the scimark-*.lua
benchmarks, so I prefer to leave it as is.
>
> Sergey
>
> On 10/24/25 13:50, Sergey Kaplun wrote:
> > This helps to avoid this library in the scanning of the test files
> > for the suite.
> > ---
> > perf/LuaJIT-benches/{ => libs}/scimark_lib.lua | 0
> > 1 file changed, 0 insertions(+), 0 deletions(-)
> > rename perf/LuaJIT-benches/{ => libs}/scimark_lib.lua (100%)
> >
> > diff --git a/perf/LuaJIT-benches/scimark_lib.lua b/perf/LuaJIT-benches/libs/scimark_lib.lua
> > similarity index 100%
> > rename from perf/LuaJIT-benches/scimark_lib.lua
> > rename to perf/LuaJIT-benches/libs/scimark_lib.lua
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list