[Tarantool-patches] [PATCH v2 luajit 7/7] test: set LD_PRELOAD only when necessary

Sergey Kaplun skaplun at tarantool.org
Tue Sep 24 18:23:55 MSK 2024


Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.

On 24.09.24, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> On 24.09.2024 13:29, Sergey Kaplun wrote:
> > This patch sets LD_PRELOAD for ASan build for the required tests instead
> > of all tests.
> >
> > Follows up tarantool/tarantool#9898
> 
> probably follows up these commits as well:
> 
> 
> commit 9f1137bcc890c28c5de24497624553574d371007    "cmake: replace prove 
> with CTest"
> 
> commit abe1e0aca3ad01f89f9d184c2a82949314814d04     "ci: execute LuaJIT 
> tests with GCC 10 and ASAN"

I've opted the previous commit (where the corresponding FIXME is
introduced). The new commit message is:

| test: set LD_PRELOAD only when necessary
|
| As a follow-up for 888adcfb72e361b150a9038407eb1dc9bd3392bd ("test: fix
| lj-802-panic-at-mcode-protfail GCC+ASan"), this patch sets LD_PRELOAD
| for ASan build for the required tests instead of all tests.
|
| Follows up tarantool/tarantool#9898


> 
> LGTM
> 
> > ---

<snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list