[Tarantool-patches] [PATCH v2 luajit 2/3] ci: add Valgrind testing workflow
Sergey Kaplun
skaplun at tarantool.org
Mon Sep 16 11:09:29 MSK 2024
Hi, Maksim!
Thanks for the patch!
Please see my comment below.
On 12.09.24, mandesero at gmail.com wrote:
> From: Maksim Tiushev <mandesero at gmail.com>
<snipped>
> + runs-on: [self-hosted, regular, Linux, x86_64]
It is worth checking the arm64 architecture too.
It is useful for backporting patches like the following:
* 003f6856 ("FFI: Don't load PC from non-function object in FFI
continuation.") [1],
* 68ffbd31 ("FFI: Don't load PC from non-function object in FFI
continuation.") [2].
See the corresponding issue [3].
So, for this patchset, you should backport the aforementioned patches
first and add the valgrind check after.
> + name: >
<snipped>
> --
> 2.34.1
>
[1]: https://github.com/LuaJIT/LuaJIT/commit/003f6856
[2]: https://github.com/LuaJIT/LuaJIT/commit/68ffbd31
[3]: https://github.com/LuaJIT/LuaJIT/issues/743
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list