[Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow

Sergey Kaplun skaplun at tarantool.org
Mon May 27 15:30:35 MSK 2024


Hi, Maxim!
Thanks for the review!
See my answers below!

On 26.05.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for the single nit below.
> 
> On Wed, May 15, 2024 at 03:32:01PM UTC, Sergey Kaplun wrote:
> > Relates to tarantool/tarantool#8473
> > ---

<snipped>

> > @@ -70,9 +70,10 @@ jobs:
> >            cmake -S . -B ${{ env.BUILDDIR }}
> >            -G Ninja
> >            ${{ matrix.CMAKEFLAGS }}
> > +          -DLUAJIT_ENABLE_GC64=ON
> I see why this change was made, but it is irrelevant to the patch.
> The decision to leave it as it is or remove is up to you.

Added the following paragraph to the commit message to avoid confusion:

| Also, this patch sorts the corresponding flags in the CI workflow
| alphabetically for better readability.

> >            -DLUAJIT_USE_ASAN=ON

<snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list