[Tarantool-patches] [PATCH luajit v3 2/6] build: fix tool components handling
Maxim Kokryashkin
max.kokryashkin at gmail.com
Wed Mar 13 17:40:14 MSK 2024
Prior to this patch, memprof/process.lua wasn't added to the
dependency list as a part of the memprof parser sources. Also,
it wasn't installed into the system along with other memprof
sources, which breaks the profile parser.
Also, the sysprof parser sources weren't handled by the
Makefile.original at all. The same applies to utils/avl.lua.
This patch fixes that, so now it's possible to properly handle
sysprof's parser.
Part of tarantool/tarantool#5994
---
Makefile.original | 16 ++++++++++++----
tools/CMakeLists.txt | 4 ++++
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/Makefile.original b/Makefile.original
index e67b6aa8..d0834fe6 100644
--- a/Makefile.original
+++ b/Makefile.original
@@ -40,6 +40,7 @@ INSTALL_JITLIB= $(INSTALL_LJLIBD)/jit
INSTALL_TOOLSLIB= $(INSTALL_LJLIBD)
INSTALL_UTILSLIB= $(INSTALL_TOOLSLIB)/utils
INSTALL_MEMPROFLIB= $(INSTALL_TOOLSLIB)/memprof
+INSTALL_SYSPROFLIB= $(INSTALL_TOOLSLIB)/sysprof
INSTALL_LMODD= $(INSTALL_SHARE)/lua
INSTALL_LMOD= $(INSTALL_LMODD)/$(ABIVER)
INSTALL_CMODD= $(INSTALL_LIB)/lua
@@ -68,10 +69,12 @@ INSTALL_PC= $(INSTALL_PKGCONFIG)/$(INSTALL_PCNAME)
INSTALL_DIRS= $(INSTALL_BIN) $(INSTALL_LIB) $(INSTALL_INC) $(INSTALL_MAN) \
$(INSTALL_PKGCONFIG) $(INSTALL_JITLIB) $(INSTALL_LMOD) $(INSTALL_CMOD) \
- $(INSTALL_UTILSLIB) $(INSTALL_MEMPROFLIB) $(INSTALL_TOOLSLIB)
+ $(INSTALL_UTILSLIB) $(INSTALL_MEMPROFLIB) $(INSTALL_SYSPROFLIB) \
+ $(INSTALL_TOOLSLIB)
UNINSTALL_DIRS= $(INSTALL_JITLIB) $(INSTALL_LJLIBD) $(INSTALL_INC) \
$(INSTALL_LMOD) $(INSTALL_LMODD) $(INSTALL_CMOD) $(INSTALL_CMODD) \
- $(INSTALL_UTILSLIB) $(INSTALL_MEMPROFLIB) $(INSTALL_TOOLSLIB)
+ $(INSTALL_UTILSLIB) $(INSTALL_MEMPROFLIB) $(INSTALL_SYSPROFLIB) \
+ $(INSTALL_TOOLSLIB)
RM= rm -f
MKDIR= mkdir -p
@@ -95,8 +98,9 @@ FILES_JITLIB= bc.lua bcsave.lua dump.lua p.lua v.lua zone.lua \
dis_arm64be.lua dis_ppc.lua dis_mips.lua dis_mipsel.lua \
dis_mips64.lua dis_mips64el.lua vmdef.lua
FILES_UTILSLIB= avl.lua bufread.lua symtab.lua
-FILES_MEMPROFLIB= parse.lua humanize.lua
-FILES_TOOLSLIB= memprof.lua
+FILES_MEMPROFLIB= humanize.lua parse.lua process.lua
+FILES_SYSPROFLIB= parse.lua
+FILES_TOOLSLIB= memprof.lua sysprof.lua
ifeq (,$(findstring Windows,$(OS)))
HOST_SYS:= $(shell uname -s)
@@ -140,6 +144,7 @@ install: $(INSTALL_DEP)
cd src/jit && $(INSTALL_F) $(FILES_JITLIB) $(INSTALL_JITLIB)
cd tools/utils && $(INSTALL_F) $(FILES_UTILSLIB) $(INSTALL_UTILSLIB)
cd tools/memprof && $(INSTALL_F) $(FILES_MEMPROFLIB) $(INSTALL_MEMPROFLIB)
+ cd tools/sysprof && $(INSTALL_F) $(FILES_SYSPROFLIB) $(INSTALL_SYSPROFLIB)
cd tools && $(INSTALL_F) $(FILES_TOOLSLIB) $(INSTALL_TOOLSLIB)
@echo "==== Successfully installed LuaJIT $(VERSION) to $(PREFIX) ===="
@echo ""
@@ -162,6 +167,9 @@ uninstall:
for file in $(FILES_MEMPROFLIB); do \
$(UNINSTALL) $(INSTALL_MEMPROFLIB)/$$file; \
done
+ for file in $(FILES_SYSPROFLIB); do \
+ $(UNINSTALL) $(INSTALL_SYSPROFLIB)/$$file; \
+ done
for file in $(FILES_TOOLSLIB); do \
$(UNINSTALL) $(INSTALL_TOOLSLIB)/$$file; \
done
diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt
index 1dfc39e4..a4adc15b 100644
--- a/tools/CMakeLists.txt
+++ b/tools/CMakeLists.txt
@@ -14,6 +14,7 @@ else()
add_custom_target(tools-parse-memprof EXCLUDE_FROM_ALL DEPENDS
memprof/humanize.lua
memprof/parse.lua
+ memprof/process.lua
memprof.lua
utils/avl.lua
utils/bufread.lua
@@ -24,6 +25,7 @@ else()
install(FILES
${CMAKE_CURRENT_SOURCE_DIR}/memprof/humanize.lua
${CMAKE_CURRENT_SOURCE_DIR}/memprof/parse.lua
+ ${CMAKE_CURRENT_SOURCE_DIR}/memprof/process.lua
DESTINATION ${LUAJIT_DATAROOTDIR}/memprof
PERMISSIONS
OWNER_READ OWNER_WRITE
@@ -61,6 +63,7 @@ else()
add_custom_target(tools-parse-sysprof EXCLUDE_FROM_ALL DEPENDS
sysprof/parse.lua
sysprof.lua
+ utils/avl.lua
utils/bufread.lua
utils/symtab.lua
)
@@ -76,6 +79,7 @@ else()
COMPONENT tools-parse-sysprof
)
install(FILES
+ ${CMAKE_CURRENT_SOURCE_DIR}/utils/avl.lua
${CMAKE_CURRENT_SOURCE_DIR}/utils/bufread.lua
${CMAKE_CURRENT_SOURCE_DIR}/utils/symtab.lua
DESTINATION ${LUAJIT_DATAROOTDIR}/utils
--
2.44.0
More information about the Tarantool-patches
mailing list