[Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout
Sergey Bronnikov
sergeyb at tarantool.org
Wed Mar 13 12:10:29 MSK 2024
Max,
thanks for review! Fixed and force-pushed.
On 3/13/24 11:56, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a few nits regarding the commit message.
> On Tue, Mar 12, 2024 at 04:51:02PM +0300, Sergey Bronnikov wrote:
>> From: Sergey Bronnikov <sergeyb at tarantool.org>
> Patch header contains a typo.
> Typo: s/c:/ci:/
Fixed.
>> Bump version of actions/checkout to v4.
>> Bump fixes an annoying warning that appears in Github WebUI:
> Typo: s/in/in the/
Fixed.
>> Node.js 16 actions are deprecated. Please update the following actions
>> to use Node.js 20: actions/checkout at v3. For more information see:
>> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
> It would be nicer to emphasize the message with | on each line:
> | Node.js 16 actions are deprecated. Please update the following actions
> | to use Node.js 20: actions/checkout at v3. For more information see:
> | https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Fixed.
>
>> ---
>> .github/workflows/coverage.yml | 2 +-
>> .github/workflows/exotic-builds-testing.yml | 2 +-
>> .github/workflows/gnumake-builds-testing.yml | 2 +-
>> .github/workflows/lint.yml | 2 +-
>> .github/workflows/sanitizers-testing.yml | 2 +-
>> .github/workflows/testing.yml | 2 +-
>> 6 files changed, 6 insertions(+), 6 deletions(-)
>>
> <snipped>
More information about the Tarantool-patches
mailing list