[Tarantool-patches] [PATCH luajit v2] Throw any errors before stack changes in trace stitching.

[Sergey Bronnikov]

Hi, Max

thanks for the patch! LGTM with a minor comment

On 3/1/24 16:21, Maxim Kokryashkin wrote:
> From: Mike Pall <mike>
>
> Thanks to doujiang24.
>
> (cherry-picked from commit 3f9389edc6cdf3f78a6896d550c236860aed62b2)
>
> The Lua stack is changed in the `recff_stitch`, so if the trace
> is aborted, for example, when the `maxsnap` is reached, and an
> error is thrown from there, the execution continues with an
> unbalanced stack.
>
> This patch adds a check for snapshot overflow to the
> `recff_stitch` to overcome the issue for the `LJ_TRERR_SNAPOV`
> case, but other cases remain unresolved and should be fixed in
> other series. For a detailed description of the remaining cases,
> see the issue[1].
>
> [1]: https://github.com/LuaJIT/LuaJIT/issues/1166

Probably it is better to remove a link to the issue to avoid spam

in GH notifications. Or replace it with "LJ#1166".


<snipped>