[Tarantool-patches] [PATCH luajit 3/4] FFI: Allow ffi.metatype() for typedefs with attributes.

Sergey Bronnikov sergeyb at tarantool.org
Thu Jun 13 18:14:39 MSK 2024


On 13.06.2024 10:34, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed your comment and force-pushed the branch.
Thanks! LGTM as I said before.
>
> On 11.06.24, Sergey Bronnikov wrote:
>> Hi, Sergey
>>
>> thanks for the patch! LGTM with a nit below.
>>
>> On 03.06.2024 17:34, Sergey Kaplun wrote:
>>> From: Mike Pall <mike>
>>>
>>> Reported by Eric Gouyer.
>>>
>>> (cherry picked from commit 27a6fee82e91319bbed8c3aa443aa2b0f1b0a470)
>>>
>>> Before the patch, `ffi.metatype()` raises an error when calling it on
>>> ctype with attributes.  This patch fixes the behaviour by using
>> extra whitespace above
>>> `ctype_raw()` instead of `ctype_get()` to follow child ctypes unless
>>> there are no attributes on the ctype.
>>>
>>> Sergey Kaplun:
>>> * added the description and the test for the problem
>>>
>>> Part of tarantool/tarantool#9924
>>> ---
> <snipped>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20240613/c7c8a924/attachment.htm>


More information about the Tarantool-patches mailing list