[Tarantool-patches] [PATCH luajit 1/2] c: disable strcmp optimization in Valgrind build

[Sergey Kaplun]

Hi, Maxim!
Thanks for the patch!
Please consider my comment below.

On 26.06.24, mandesero at gmail.com wrote:
> From: mandesero <mandesero at gmail.com>
> 
> ---
>  src/lj_str.c | 43 +++++++++++++++++++++++++++++++++++++++++--

AFAICS, the <src/lj.supp> contains Valgrind suppressions for
`lj_str_cmp()` and `str_fastcmp()`. The upstream politics until
ff34b48ddd6f2b3bdd26d6088662a214ba6b0288 ("Redesign and harden string
interning.") [1] is to use this file for all suppressions (see the
corresponding comments in the commit). So I suggest dropping this patch
and introducing testing with suppressions in the CI in another patch (as
it is done). Are there any objections to this?

[1]: https://github.com/LuaJIT/LuaJIT/commit/ff34b48ddd6f2b3bdd26d6088662a214ba6b0288

>  1 file changed, 41 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lj_str.c b/src/lj_str.c
> index 321e8c4f..00cced03 100644
> --- a/src/lj_str.c
> +++ b/src/lj_str.c

<snipped>

> -- 
> 2.34.1
> 

-- 
Best regards,
Sergey Kaplun