[Tarantool-patches] [PATCH luajit 03/25] test: enable <ffi_arith_ptr.lua> in LuaJIT-tests

Sergey Kaplun skaplun at tarantool.org
Tue Jan 23 16:10:40 MSK 2024


Hi, Sergey!
Thanks for the review!

On 23.01.24, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> thanks for the patch.
> 
> On 1/19/24 14:32, Sergey Kaplun wrote:
> > This patch changes `dofile()` to the corresponding `require()` of the
> > helper function. It adds test names and includes the test in <index>.
> 
> What for do you need replace `dofile()` with `require()`?
> 
> I believe it is important to say not only *what* commit do but also 
> *why* it do these changes.

I added the following note to all commits mentioned this change:
| (which uses an unreliable relative file path and mutates `_G` with
| global functions to be defined)

Branch is force-pushed.

> 
> <snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list