[Tarantool-patches] [PATCH luajit] ARM64: Allow building with unwinding disabled.
Sergey Bronnikov
sergeyb at tarantool.org
Tue Jan 16 12:47:29 MSK 2024
Max, thanks for correction! LGTM as I said before
On 1/9/24 17:18, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the review!
> On Fri, Dec 29, 2023 at 04:40:23PM +0300, Sergey Bronnikov wrote:
>> Hello, Max!
>>
>> thanks for the patch! LGTM with a minor comment
>>
>> On 12/11/23 14:26, Maksim Kokryashkin wrote:
>>> From: Mike Pall <mike>
>>>
>>> (cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16)
>>>
>>> Prior to this patch, the LuaJIT build with the
>>> `-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of
>>> linker relocation errors related to dwarf-specific code. This
>> probably it is worth adding an error message produced by linker.
>>
>> Feel free to ignore.
> Added. Here is the new commit message:
> ===
> ARM64: Allow building with unwinding disabled.
>
> (cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16)
>
> Prior to this patch, the LuaJIT build with the
> `-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of
> linker relocation error related to dwarf-specific code:
> | /usr/bin/ld: lj_vm_dyn.o: relocation R_AARCH64_PREL32 against
> | symbol `lj_err_unwind_dwarf' which may bind externally can not
> | be used when making a shared object; recompile with -fPIC
> | lj_vm_dyn.o:(.eh_frame+0x12): dangerous relocation: unsupported
> | relocation
>
> This patch disables emission of the `.eh_frame` section for
> builds without unwinding to solve the issue.
>
> The `LUAJIT_NO_UNWIND` build option is added to CMakeLists.txt.
> This patch adds this build flavor to our exotic builds workflow.
>
> Maxim Kokryashkin:
> * added the description for the problem
>
> Part of tarantool/tarantool#9145
> ===
>>
>> <snipped>
>>
More information about the Tarantool-patches
mailing list