[Tarantool-patches] [PATCH luajit] test: harden skipcond for libc in LuaJIT-tests
Sergey Kaplun
skaplun at tarantool.org
Mon Dec 23 11:18:48 MSK 2024
Hi, Maxim!
Thanks for the review!
On 23.12.24, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for the single nit below.
>
> On Thu, Dec 19, 2024 at 12:30:41PM +0300, Sergey Kaplun wrote:
> > The `strtod parsing` subtest in the <lib/base/tonumber_scan.lua> checks
> > the results yielded by the `strtod()` via FFI call. In glibc versions
> > before 2.28 it returns an incorrect result (NaN instead of inf) for
> > "0x3p1023" [1]. This patch hardens the skipcond for this test for a
> > smaller version of the libc installed.
> I believe these versions are usually referred to as `older`, not
> `smaller`. Feel free to ignore.
Replaced, as you suggested. Rebased branch on the current master and
force pushed with the fix.
>
> Side note: I agree with Sergey Bronnikov here, we should really try
> and push the operating systems that have reached their EOL out of
> our CI, so we can focus on something that matters.
Agree here too.
>
> >
> > [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=23279
> > ---
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list