[Tarantool-patches] [PATCH v2 luajit 31/45] test: refactor <lang/gc_stack.lua> LuaJIT test

Sergey Bronnikov sergeyb at tarantool.org
Thu Aug 29 12:45:57 MSK 2024


Hi, Sergey,

On 26.08.2024 09:56, Sergey Kaplun wrote:


<snipped>

>> thanks for the patch! LGTM with a minor:
>>
>> probably line 10 needs more whitespaces:
>>
>>   >      do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame
>> size.
> Fixed thanks!
> See the iterative patch below.
>
> ===================================================================
> diff --git a/test/LuaJIT-tests/lang/gc_stack.lua b/test/LuaJIT-tests/lang/gc_stack.lua
> index 8aee57e3..d05d4402 100644
> --- a/test/LuaJIT-tests/lang/gc_stack.lua
> +++ b/test/LuaJIT-tests/lang/gc_stack.lua
> @@ -7,7 +7,10 @@ do --- Marking sparse stack.
>       else
>         return t[k] -- Leaves holes in each frame.
>       end
> -    do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame size.
> +    do
> +      -- Ensure bigger frame size.
> +      local a, b, c, d, e, f, g, h, i, j, k, l, m, n
> +    end
>     end})
>     local x = t[50]
>   end
> ===================================================================
>
Thanks! LGTM
<snipped>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20240829/f582ed14/attachment.htm>


More information about the Tarantool-patches mailing list