[Tarantool-patches] [PATCH v2 luajit 35/45] test: enable <misc/stackovc.lua> LuaJIT test

Sergey Bronnikov sergeyb at tarantool.org
Fri Aug 23 18:41:38 MSK 2024


Sergey,

On 22.08.2024 17:36, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Please consider my answer below.
>
> On 22.08.24, Sergey Bronnikov wrote:
>> Sergey,
>>
>> On 21.08.2024 11:58, Sergey Kaplun wrote:
>>> This patch moves the aforementioned test from the <misc> to the <lang/>
>>> directory (with slightly renaming to be consistent with other names),
>>> includes it in <index>, and names the subtest.
>>>
>>> Part of tarantool/tarantool#9398
>>> ---
>> thanks for the patch! LGTM with comment below.
>>>    test/LuaJIT-tests/lang/index         |  1 +
>>>    test/LuaJIT-tests/lang/stackov_c.lua | 12 ++++++++++++
>> May be "stackoverflow_coro.lua"?
> I suppose the main idea is the possible stack overflow in the C function
> (more accurate built-in function) `unpack`. I prefer to leave the old
> name to avoid confusion.
>
>
LGTM as I said before.


<snipped>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20240823/29c8a83c/attachment.htm>


More information about the Tarantool-patches mailing list