[Tarantool-patches] [PATCH v2 luajit 15/45] test: enable <misc/gcstep.lua> LuaJIT test
Sergey Bronnikov
sergeyb at tarantool.org
Thu Aug 22 18:07:30 MSK 2024
On 22.08.2024 15:57, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> See my answers below.
>
> On 22.08.24, Sergey Bronnikov wrote:
>> Sergey,
>>
>> On 21.08.2024 11:58, Sergey Kaplun wrote:
>>> This patch moves the aforementioned test from the <misc> to the <lang/>
>>> directory (with slightly renaming to be consistent with other names),
>>> includes it in <index>, and names the subtests.
>>>
>>> Part of tarantool/tarantool#9398
>>> ---
>> thanks for the patch! Please adjust a width of lines in commit message.
> The commit message is already adjusted correct: the maximum width is 72
> symbols (see [1]). Or what do you mean?
Seems I forgot a number for max line length in a commit message body :-/
LGTM
>
>> LGTM
>>
> <snipped>
>
> [1]:https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20240822/cfc99044/attachment.htm>
More information about the Tarantool-patches
mailing list