[Tarantool-patches] [PATCH v2 luajit 13/45] test: enable <misc/gc_trace.lua> LuaJIT test
Sergey Kaplun
skaplun at tarantool.org
Thu Aug 22 15:54:45 MSK 2024
Sergey,
Thanks for the review!
Please consider my answers below.
On 22.08.24, Sergey Bronnikov wrote:
> Sergey,
>
> On 21.08.2024 11:58, Sergey Kaplun wrote:
> > This patch moves the aforementioned test from the <misc> to the <trace/>
> > directory, includes it in <index>, and names subtests.
> >
> > The first test is adjusted to be runable in the test suite.
> >
> > Part of tarantool/tarantool#9398
> > ---
> thanks for the patch! LGTM with two minor comments below.
<snipped>
> > +do --- Collect dead traces.
> > + jit.flush()
> > + collectgarbage()
> > + -- Prevent the creation of side traces.
> > + jit.off()
> > + for j=1,100 do
> add whitespaces please
It is refactored in the next patch
> > + jit.on()
> > + loadstring("for i=1,100 do end")()
> and here too
Ditto.
> > + jit.off()
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list