[Tarantool-patches] [PATCH v2 luajit 06/45] test: remove <misc/coro_yield.lua> LuaJIT test

Sergey Kaplun skaplun at tarantool.org
Wed Aug 21 19:36:33 MSK 2024


Hi, Sergey!
Thanks for the review!
Please consider my answers below.

On 21.08.24, Sergey Bronnikov wrote:
> Sergey,
> 
> thanks for the patch!
> 
> On 21.08.2024 11:58, Sergey Kaplun wrote:
> > This patch removes the aforementioned test since it is identical to the
> 
> Line's width is 70 symbols, please split.

The maximum line's width is 72 symbols, see [1]. It is 71 here, so
ignoring.

Side note: I use (if not forgot) the Vim auto-formatting for the gitcommit.
For the code style, it needs some tuning and configuration.
:help v_gq

> 
> LGTM
> 
> > <lib/coroutine/yield.lua> test, which wasn't cleaned up during the
> > refactoring in the original repository.
> >
> > Part of tarantool/tarantool#9398
> > ---
> <snipped>

[1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list