[Tarantool-patches] [PATCH luajit 2/2] OSX/iOS: Always generate 64 bit non-FAT Mach-O object files.
Maxim Kokryashkin
m.kokryashkin at tarantool.org
Mon Aug 19 12:45:55 MSK 2024
Hi, Sergey!
Thanks for the patch!
As this thread replies grew way beyond comprehensible limit, I'll refer
to the GitHub commit instead.
> Sergey Bronnikov:
> * added the description and the trimmed the test for the problem
Typo: s/the trimmed/trimmed/
<lj-865-cross-generation-mach-o-file.test.lua>
Lines: 149-150:
> -- The function builds a Mach-O object file and retrieves its
> -- header fields.
I believe, "validates" fits better than "retrieves" here.
Line: 153:
> -- LuaJIT always generate 64-bit, non-FAT Mach-O object files.
Typo: s/generate/generates/
Otherwise, LGTM.
More information about the Tarantool-patches
mailing list