[Tarantool-patches] [PATCH luajit 01/36] test: don't run JIT-based LuaJIT tests without JIT
Sergey Kaplun
skaplun at tarantool.org
Mon Aug 19 11:47:09 MSK 2024
Hi, Sergey!
Thanks for the review!
On 15.08.24, Sergey Bronnikov wrote:
> Hi, Sergey
>
> thanks for the patch, LGTM.
>
> See a minor comment below.
>
>
> Sergey
>
> On 14.08.2024 16:55, Sergey Kaplun wrote:
<snipped>
> > COMMAND ${LUAJIT_TEST_COMMAND} ${CMAKE_CURRENT_SOURCE_DIR}/test.lua
> > - +slow +ffi +bit +jit ${LUAJIT_TEST_TAGS_EXTRA}
> > + +slow +ffi +bit ${LUAJIT_TEST_TAGS_EXTRA}
>
> LUAJIT_TEST_TAGS_EXTRA is a list and to convert CMake list to a
> whitespace-separated strings
>
> a list should be put in double quotes.
>
> However, I've run tests with options for avx512 and -DLUAJIT_NO_UNWIND=ON
>
> and passing test flags works fine without double quotes.
With double quotes, these flags would be treated as "+jit +avx512"
instead of separate flags +jit +avx512, so I leave it as is.
>
> > WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
> > )
> > set_tests_properties("${test_title}" PROPERTIES
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list