[Tarantool-patches] [PATCH luajit] Fix handling of instable types in TNEW/TDUP load forwarding.
Sergey Bronnikov
sergeyb at tarantool.org
Fri Sep 15 10:28:05 MSK 2023
Hi, Sergey
thanks for the patch! LGTM
And see my minor comments below.
On 8/29/23 12:54, Sergey Kaplun wrote:
<snipped>
> -- TDUP.
> ---[[
> --- FIXME: Disable test case for now. Enable, with another
> --- backported commit with a fix for the aforementioned issue
> --- (and after patch "Improve assertions.").
> --- Test taken trace exits too.
> for _ = 1, 5 do
> local t = slot
> -- Now use constant key slot to get necessary branch.
> @@ -48,6 +43,5 @@ for _ = 1, 5 do
Nit: assert is triggered with 3 iterations too
> slot = _ % 2 ~= 0 and stored_tab or {true}
Nit: I would left a comment with explanation why exactly this value is
assigned to slot.
> end
> test:is(result, true, 'TDUP load forwarding was successful')
> -]]
>
> test:done(true)
More information about the Tarantool-patches
mailing list