[Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers

Sergey Bronnikov sergeyb at tarantool.org
Thu Sep 14 12:22:15 MSK 2023


Hi, Max

Thanks for the fixes!

Two new comments:

$  ./build/src/luajit -ts sysprof.bin
./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate 
local 'magic' (a nil value)


Please fix.


$  ./build/src/luajit -ts mee
./build/src/luajit: ./tools/utils/bufread.lua:122: fopen, errno: 2


Seems the case is not handled in your code, let's fix it.


On 9/12/23 23:03, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed all of your comments, except for the one about
> `luacheckrc` and _TARANTOOL. I believe, it should be
> done in a separate patch.
>
<snipped>


More information about the Tarantool-patches mailing list