[Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers
Sergey Kaplun
skaplun at tarantool.org
Sun Sep 3 12:50:43 MSK 2023
Hi, Maxim!
Thanks for the patch!
LGTM, with a single nit below.
> +static int runtoolcmd(lua_State *L, const char *tool_name)
> +{
> + lua_getglobal(L, "require");
> + lua_pushstring(L, tool_name);
> + if (lua_pcall(L, 1, 1, 0)) {
> + const char *msg = lua_tostring(L, -1);
> + if (msg) {
> + if (!strncmp(msg, "module ", 7))
> + msg = "unknown luaJIT command or tools not installed";
Nit: Use tab here for indentation.
> + l_message(progname, msg);
> + }
> + return 1;
> + }
> + lua_getglobal(L, "arg");
> + return report(L, lua_pcall(L, 1, 1, 0));
> +}
> +
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list