[Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell

[Maxim Kokryashkin]

Hi, Sergey!
Thanks for the fixes!
LGTM
--
Best regards,
Maxim Kokryashkin
 
  
>Вторник, 31 октября 2023, 13:51 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches at dev.tarantool.org>:
> 
>Hello,
>
>On 10/31/23 09:42, Sergey Kaplun wrote:
>> Hi, Sergey!
>> One more comment below:
>>
><snipped>
>> --- a/cmake/CodeSpell.cmake
>> +++ b/cmake/CodeSpell.cmake
>> @@ -1,13 +1,25 @@
>>  find_program(CODESPELL codespell)
>>
>>  string(JOIN "," CODESPELL_WHITELIST
>> +  ${PROJECT_SOURCE_DIR}/src/lib_misc.c
>>    ${PROJECT_SOURCE_DIR}/src/lj_mapi.c
>> +  ${PROJECT_SOURCE_DIR}/src/lj_memprof.c
>> +  ${PROJECT_SOURCE_DIR}/src/lj_memprof.h
>>    ${PROJECT_SOURCE_DIR}/src/lj_sysprof.c
>> +  ${PROJECT_SOURCE_DIR}/src/lj_sysprof.h
>> +  ${PROJECT_SOURCE_DIR}/src/lj_utils.h
>>    ${PROJECT_SOURCE_DIR}/src/lj_utils_leb128.c
>>    ${PROJECT_SOURCE_DIR}/src/lj_wbuf.c
>> +  ${PROJECT_SOURCE_DIR}/src/lj_wbuf.h
>> +  ${PROJECT_SOURCE_DIR}/src/lmisclib.h
>>    ${PROJECT_SOURCE_DIR}/src/luajit-gdb.py
>>    ${PROJECT_SOURCE_DIR}/src/luajit_lldb.py
>>    ${PROJECT_SOURCE_DIR}/test/CMakeLists.txt
>> +  ${PROJECT_SOURCE_DIR}/test/lua-Harness-tests/CMakeLists.txt
>> +  ${PROJECT_SOURCE_DIR}/test/LuaJIT-tests/CMakeLists.txt
>> +  ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
>> +  ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
>> + ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt
>>    ${PROJECT_SOURCE_DIR}/test/tarantool-c-tests
>>    ${PROJECT_SOURCE_DIR}/test/tarantool-tests
>>    ${PROJECT_SOURCE_DIR}/tools
>>> Side note: within vim's (sort 'l' is greater then 'L', see `man ascii`),
>>> but I'm OK with this order too.
>> Sorry, I've forgot about <src/lj_symtab.c> <src/lj_symtab.h>.
>
>Added:
>
>--- a/cmake/CodeSpell.cmake
>+++ b/cmake/CodeSpell.cmake
>@@ -5,6 +5,8 @@ string(JOIN "," CODESPELL_WHITELIST
>    ${PROJECT_SOURCE_DIR}/src/lj_mapi.c
>    ${PROJECT_SOURCE_DIR}/src/lj_memprof.c
>    ${PROJECT_SOURCE_DIR}/src/lj_memprof.h
>+  ${PROJECT_SOURCE_DIR}/src/lj_symtab.c
>+  ${PROJECT_SOURCE_DIR}/src/lj_symtab.h
>    ${PROJECT_SOURCE_DIR}/src/lj_sysprof.c
>    ${PROJECT_SOURCE_DIR}/src/lj_sysprof.h
>    ${PROJECT_SOURCE_DIR}/src/lj_utils.h
>
>>
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20231031/a9e5e8fa/attachment.htm>