[Tarantool-patches] [PATCH luajit v3 2/2] Fix snapshot PC when linking to BC_JLOOP that was a BC_RET*.

Sergey Bronnikov sergeyb at tarantool.org
Sun Nov 26 18:14:25 MSK 2023


Hi, Maxim

LGTM with a minor comment

On 10/4/23 15:50, Maksim Kokryashkin wrote:


<snipped>

> --- /dev/null
> +++ b/test/tarantool-tests/lj-624-jloop-snapshot-pc.test.lua
> @@ -0,0 +1,84 @@
> +local tap = require('tap')
> +local test = tap.test('lj-624-jloop-snapshot-pc'):skipcond({
> +  ['Test requires JIT enabled'] = not jit.status(),
> +})
> +
> +test:plan(1)
> +-- XXX: The test case below triggers the assertion that was
> +-- added in the patch if tested without the fix itself. It
> +-- is hard to create a stable reproducer without turning off
> +-- ASLR and VM randomizations, which is not suitable for testing.
Probably it would be useful to say it in commit message.


<snipped>



More information about the Tarantool-patches mailing list