[Tarantool-patches] [PATCH luajit 1/3][v2] Add 'cc' file type for saving bytecode.

Sergey Kaplun skaplun at tarantool.org
Mon Nov 13 10:04:16 MSK 2023


Hi, Sergey!
Thanks for the patch.
LGTM, after fixing my nits below.

On 09.11.23, Sergey Bronnikov wrote:
> From: Mike Pall <mike>
> 
> Contributed by Sergey Bronnikov. #1105

Minor: I suggest dropping #1105 here to avoid spamming to the ticket
during development.

> 
> (cherry picked from commit e826d0c101d750fac8334d71e221c50d8dbe236c)
> 
> The patch adds a file type `cc` that allows exporting byte code directly
> to a file with extension `.cc`.

Typo: s/extension/the extension/

I suppose it is worth mentioning that the test will be added within
future commits?

> 
> Sergey Bronnikov:
> * added the description
> 
> Part of tarantool/tarantool#9145
> ---

<snipped>

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list