[Tarantool-patches] [PATCH luajit v2 1/2] Print errors from __gc finalizers instead of rethrowing them.

Maxim Kokryashkin m.kokryashkin at tarantool.org
Thu Nov 9 03:03:38 MSK 2023


Hi, Sergey!
Thanks for the review.
Fixed, your comments, branch is force-pushed, here is the diff:
===
diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua
index 71efc260..450ca8d4 100644
--- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua
+++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua
@@ -21,8 +21,8 @@ local function test_f()
   -- Make GC aggressive enough to end the atomic phase before
   -- exiting the trace.
   collectgarbage('setstepmul', 400)
-  -- The number of iterations is empirical, just big enough for the
-  -- issue to strike.
+  -- The number of iterations is empirical, just big enough for
+  -- the issue to strike.
   for _ = 1, 4000 do
     new_bad_cdata()
   end
diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua
index dfef11e5..f0d11f6f 100644
--- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua
+++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua
@@ -7,5 +7,5 @@ test:plan(1)
 
 local script = require('utils').exec.makecmd(arg, { redirect = '2>&1' })
 local output = script()
-test:like(output, '.*ERROR in finalizer:.*')
+test:like(output, 'ERROR in finalizer:')
 test:done(true)
diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua
index fdd9ced1..3fe48c77 100644
--- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua
+++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua
@@ -9,8 +9,8 @@ local function test_f()
   -- Make GC aggressive enough to end the atomic phase before
   -- exiting the trace.
   collectgarbage('setstepmul', 400)
-  -- The number of iterations is empirical, just big enough for the
-  -- issue to strike.
+  -- The number of iterations is empirical, just big enough for
+  -- the issue to strike.
   for _ = 1, 4000 do
     new_bad_cdata()
   end
===


More information about the Tarantool-patches mailing list